From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 19 Mar 2013 09:59:21 +0200 From: Johan Hedberg To: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Fix bogus __le16_to_cpu call Message-ID: <20130319075921.GA16093@x220> References: <1363678634-15338-1-git-send-email-johan.hedberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1363678634-15338-1-git-send-email-johan.hedberg@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Tue, Mar 19, 2013, Johan Hedberg wrote: > The type member of struct hci_rp_read_page_scan_type is u8 so no > byte order conversion is necessary for it. This patch removes a bogus > call to __le16_to_cpu on it. > > Signed-off-by: Johan Hedberg > --- > net/bluetooth/hci_event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c > index 8a1f511..1385807 100644 > --- a/net/bluetooth/hci_event.c > +++ b/net/bluetooth/hci_event.c > @@ -641,7 +641,7 @@ static void hci_cc_read_page_scan_type(struct hci_dev *hdev, > BT_DBG("%s status 0x%2.2x", hdev->name, rp->status); > > if (test_bit(HCI_INIT, &hdev->flags) && !rp->status) > - hdev->page_scan_type = __le16_to_cpu(rp->type); > + hdev->page_scan_type = rp->type; > } > > static void hci_cc_write_page_scan_type(struct hci_dev *hdev, Just ignore this one. I should have checked for new emails on linux-bluetooth before creating it since this was already taken care of. Johan