From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Alex Deymo <deymo@chromium.org>
Cc: linux-bluetooth@vger.kernel.org, keybuk@chromium.org
Subject: Re: [PATCH v3 2/6] client: Right prompt management on agent input
Date: Wed, 20 Mar 2013 15:22:59 -0300 [thread overview]
Message-ID: <20130320182259.GC6190@samus> (raw)
In-Reply-To: <1363726505-15171-3-git-send-email-deymo@chromium.org>
Hi Alex,
On 13:55 Tue 19 Mar, Alex Deymo wrote:
> Registering an agent shares the user input interface with the normal console
> command interface. The way it is implemented (using rl_message, rl_save_prompt
> and rl_restore_prompt) conflicts with the rl_printf calls that may appear
> while waiting for user input, loosing the [bluetooth]# prompt.
> This patch fixes this and makes clear if the expected input is a command or an
> agent reply changing the color and text of the prompt.
Seems that there are some minor issues with formatting:
[bluetooth]# pair 40:98:4E:XX:XX:XX
Attempting to pair with 40:98:4E:XX:XX:XX
[CHG] Device 40:98:4E:XX:XX:XX Connected: yes
Request confirmation
[blue1m[agent] Confirm passkey 368383 (yes/no): yes
And I would suggest adding a patch to make bluetoothctl register itself as a
default agent by default. I needed to enable it manually before it could
handle incomming pairing requests.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2013-03-20 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 20:54 [PATCH v3 0/6] client: agent implementation on bluetoothctl Alex Deymo
2013-03-19 20:55 ` [PATCH v3 1/6] client: Add color modifiers to NEW, CHG and DEL events Alex Deymo
2013-03-19 20:55 ` [PATCH v3 2/6] client: Right prompt management on agent input Alex Deymo
2013-03-20 18:22 ` Vinicius Costa Gomes [this message]
2013-03-19 20:55 ` [PATCH v3 3/6] client: "agent" command capability argument and autocompletion Alex Deymo
2013-03-19 20:55 ` [PATCH v3 4/6] client: Agent's DisplayPincode implementation Alex Deymo
2013-03-19 20:55 ` [PATCH v3 5/6] client: Agent's DisplayPasskey implementation Alex Deymo
2013-03-19 20:55 ` [PATCH v3 6/6] client: Agent's RequestPasskey implementation Alex Deymo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320182259.GC6190@samus \
--to=vinicius.gomes@openbossa.org \
--cc=deymo@chromium.org \
--cc=keybuk@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox