From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Fix Inquiry command support in HCI request framework
Date: Tue, 2 Apr 2013 10:07:46 +0300 [thread overview]
Message-ID: <20130402070746.GA5376@x220> (raw)
In-Reply-To: <1364425497-30944-1-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Wed, Mar 27, 2013, Andre Guedes wrote:
> This v2 implements the following comments about the previous patch set:
> - Consider commands (which don't send Command Complete Event) as completed
> based on Command Status Event.
> - Remove hci_req_cmd_status function.
>
> Thus, for those HCI commands which don't send Command Complete Event, the HCI
> request framework considers they have completed when the Command Status Event
> is received.
>
> Regards,
>
> Andre
>
> Andre Guedes (3):
> Bluetooth: Fix HCI request framework
> Bluetooth: Fix hci_inquiry
> Bluetooth: Remove hci_req_cmd_status
>
> include/net/bluetooth/hci_core.h | 1 -
> net/bluetooth/hci_core.c | 39 +++++++++++++--------------------------
> net/bluetooth/hci_event.c | 11 ++++++-----
> 3 files changed, 19 insertions(+), 32 deletions(-)
I did a bit of testing and these patches seem to work fine. I'm not
really familiar with the smp_mb__after_clear_bit() usage, but I'll
assume you did your homework to ensure it's correct. Other than that the
patches seem fine to me.
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Johan
next prev parent reply other threads:[~2013-04-02 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 23:04 [PATCH v2 0/3] Fix Inquiry command support in HCI request framework Andre Guedes
2013-03-27 23:04 ` [PATCH v2 1/3] Bluetooth: Fix " Andre Guedes
2013-03-27 23:04 ` [PATCH v2 2/3] Bluetooth: Fix hci_inquiry Andre Guedes
2013-03-27 23:04 ` [PATCH v2 3/3] Bluetooth: Remove hci_req_cmd_status Andre Guedes
2013-04-02 7:07 ` Johan Hedberg [this message]
2013-04-04 8:26 ` [PATCH v2 0/3] Fix Inquiry command support in HCI request framework Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402070746.GA5376@x220 \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).