From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 0/6] Use __sync_* instead of g_atomic_*
Date: Wed, 3 Apr 2013 11:20:18 -0300 [thread overview]
Message-ID: <20130403142018.GE2715@samus> (raw)
In-Reply-To: <1364943285-12463-1-git-send-email-lucas.demarchi@profusion.mobi>
Hi,
On 19:54 Tue 02 Apr, Lucas De Marchi wrote:
> These patches fix build with gcc >= 4.8. I'd prefer to use plain ++/-- for
> these refcounts since we are not running multiple threads, but I'm preserving
> the previous behavior.
>
> Note in some of the commits that the use of atomic operations was wrong, and it
> was not noticed only because there aren't multiple threads.
>
> It's an RFC because it's only compile-tested (and 'make check' was executed as
> well). Please take a look in the patches and tell me if we want
> to continue with atomic operations. Then I can run some tests tomorrow.
Just to (publicly) clarify a doubt that I had, in case it matters to anyone
else, clang also has these built-ins.
Cheers,
--
Vinicius
prev parent reply other threads:[~2013-04-03 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 22:54 [RFC 0/6] Use __sync_* instead of g_atomic_* Lucas De Marchi
2013-04-02 22:54 ` [RFC 1/6] gitignore: Ignore file generated by Automake 1.13 Lucas De Marchi
2013-04-02 22:54 ` [RFC 2/6] gdbus: Use gcc builtin instead of g_atomic Lucas De Marchi
2013-04-02 22:54 ` [RFC 3/6] attrib: " Lucas De Marchi
2013-04-03 2:25 ` Lucas De Marchi
2013-04-02 22:54 ` [RFC 4/6] gobex: " Lucas De Marchi
2013-04-02 22:54 ` [RFC 5/6] obexd: " Lucas De Marchi
2013-04-02 22:54 ` [RFC 6/6] " Lucas De Marchi
2013-04-02 23:39 ` Lucas De Marchi
2013-04-02 22:54 ` [RFC 6/6] shared: " Lucas De Marchi
2013-04-03 14:20 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403142018.GE2715@samus \
--to=vinicius.gomes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox