Linux bluetooth development
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Alex Deymo <deymo@chromium.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
	keybuk@chromium.org
Subject: Re: [PATCH v4 0/2] Input1 Connectability revisited
Date: Thu, 4 Apr 2013 18:44:44 -0300	[thread overview]
Message-ID: <20130404214444.GA7065@echo> (raw)
In-Reply-To: <1365111113-13741-1-git-send-email-deymo@chromium.org>

Hi Alex,

On 14:31 Thu 04 Apr, Alex Deymo wrote:
> New version of this patch using Vinicius idea of ReconnectMode, except that
> instead of "passive" and "active" we use "Host" and "Device", since the
> the passive/active is relative to what end are you talking about (host/device)
> Names are free to change.

Sounds good to me. Just please change to lower case names to maintain
consistency with the rest of the API, see media-api.txt, for example.

> 
> Also, this patch set removes the input config file introduced in a previous
> version of this patch. This property is readonly after all, and is derived
> from the SDP record passed to the Input plugin init (input_device_register).
> This SDP record comes from the SDP cache and hid_device_probe ensures it is
> not NULL.
> 
> Comments are welcomed!
> 
> Alex Deymo (2):
>   input: Documentation for new Input1 interface
>   input: Implement the new ReconnectMode Input1 property.
> 
>  doc/input-api.txt       | 32 ++++++++++++++++++
>  profiles/input/device.c | 89 +++++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 118 insertions(+), 3 deletions(-)
>  create mode 100644 doc/input-api.txt
> 
> -- 
> 1.8.1.3
> 

Cheers,
-- 
Vinicius

  parent reply	other threads:[~2013-04-04 21:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 21:31 [PATCH v4 0/2] Input1 Connectability revisited Alex Deymo
2013-04-04 21:31 ` [PATCH v4 1/2] input: Documentation for new Input1 interface Alex Deymo
2013-04-04 21:31 ` [PATCH v4 2/2] input: Implement the new ReconnectMode Input1 property Alex Deymo
2013-04-04 21:49   ` Vinicius Costa Gomes
2013-04-04 21:44 ` Vinicius Costa Gomes [this message]
2013-04-05  2:47   ` [PATCH v4 0/2] Input1 Connectability revisited Alex Deymo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130404214444.GA7065@echo \
    --to=vinicius.gomes@openbossa.org \
    --cc=deymo@chromium.org \
    --cc=keybuk@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox