From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Tedd Ho-Jeong An <tedd.an@intel.com>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
don.fry@intel.com
Subject: Re: [RFC] Bluetooth: Add support for Intel Bluetooth device [8087:07dc]
Date: Thu, 11 Apr 2013 07:04:19 +0900 [thread overview]
Message-ID: <20130410220419.GA17338@x220> (raw)
In-Reply-To: <6C02E13F-AA1A-43B9-891F-8B42F9111DD8@holtmann.org>
Hi Marcel,
On Wed, Apr 10, 2013, Marcel Holtmann wrote:
> > + const u8 *patch_curr;
> > + char pfile[32];
> > + u8 *m_off_code;
> > +
> > + u8 m_on[] = { 0x01, 0x00 };
> > + u8 m_off_1[] = { 0x00, 0x01 };
> > + u8 m_off_2[] = { 0x00, 0x02 };
>
> Shouldn't this be __u8. Johan, any preference. I know that I used __u8
> for the bcm92035 vendor command.
To my understanding __u8 (and __u16 and __u32 too) are intended for code
that's to be shared with user space (e.g. our upcoming uapi header
file(s)). Anything else should just use u8. At least this is what I
discovered after some research when I get more heavily involved with
kernel development a few years ago.
Johan
next prev parent reply other threads:[~2013-04-10 22:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 2:44 [RFC] Bluetooth: Add support for Intel Bluetooth device [8087:07dc] Tedd Ho-Jeong An
2013-04-10 15:40 ` Fry, Don
2013-04-10 16:23 ` Tedd Ho-Jeong An
2013-04-10 16:11 ` Marcel Holtmann
2013-04-10 16:34 ` Tedd Ho-Jeong An
2013-04-10 22:04 ` Johan Hedberg [this message]
2013-04-10 22:09 ` Marcel Holtmann
2013-04-11 19:35 ` Gustavo Padovan
2013-04-10 23:57 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410220419.GA17338@x220 \
--to=johan.hedberg@gmail.com \
--cc=don.fry@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox