Linux bluetooth development
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Use separate function for BCM92035 vendor setup
Date: Thu, 11 Apr 2013 03:07:06 -0300	[thread overview]
Message-ID: <20130411060706.GB19253@joana> (raw)
In-Reply-To: <1365606695-43841-1-git-send-email-marcel@holtmann.org>

Hi Marcel,

* Marcel Holtmann <marcel@holtmann.org> [2013-04-10 08:11:35 -0700]:

> Trying to squeeze every single vendor setup routine into the same function
> and have it assigned all the time is actually a bad idea. Especially since
> the core can handle the absence of a setup routine perfectly fine.
> 
> To make this a lot simpler for future additions of vendor setup code,
> split the BCM92035 setup into its own function and only assign it when
> this specific device has been detected.
> 
> Doing it like this has the nice side benefit that we do not have to keep
> a copy of the driver_info around.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  drivers/bluetooth/btusb.c | 52 ++++++++++++++++++++++-------------------------
>  1 file changed, 24 insertions(+), 28 deletions(-)

Patch has been applied to bluetooth-next. Thanks.

	Gustavo

      reply	other threads:[~2013-04-11  6:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 15:11 [PATCH] Bluetooth: Use separate function for BCM92035 vendor setup Marcel Holtmann
2013-04-11  6:07 ` Gustavo Padovan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411060706.GB19253@joana \
    --to=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox