From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 17 Apr 2013 11:30:05 +0300 From: Johan Hedberg To: Andre Guedes Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH 05/17] Bluetooth: Make inquiry_cache_flush non-static Message-ID: <20130417083005.GE6637@x220> References: <1365117675-2202-1-git-send-email-andre.guedes@openbossa.org> <1365117675-2202-6-git-send-email-andre.guedes@openbossa.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1365117675-2202-6-git-send-email-andre.guedes@openbossa.org> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andre, On Thu, Apr 04, 2013, Andre Guedes wrote: > In order to use HCI request framework in start_discovery, we'll need > to call inquiry_cache_flush in mgmt.c. Therefore, this patch makes > inquiry_cache_flush non-static > > Signed-off-by: Andre Guedes > --- > include/net/bluetooth/hci_core.h | 1 + > net/bluetooth/hci_core.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h > index 0e7ee89..4713514 100644 > --- a/include/net/bluetooth/hci_core.h > +++ b/include/net/bluetooth/hci_core.h > @@ -431,6 +431,7 @@ void hci_inquiry_cache_update_resolve(struct hci_dev *hdev, > struct inquiry_entry *ie); > bool hci_inquiry_cache_update(struct hci_dev *hdev, struct inquiry_data *data, > bool name_known, bool *ssp); > +void inquiry_cache_flush(struct hci_dev *hdev); > > /* ----- HCI Connections ----- */ > enum { > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > index 43ea7e3..eecab8e 100644 > --- a/net/bluetooth/hci_core.c > +++ b/net/bluetooth/hci_core.c > @@ -630,7 +630,7 @@ void hci_discovery_set_state(struct hci_dev *hdev, int state) > hdev->discovery.state = state; > } > > -static void inquiry_cache_flush(struct hci_dev *hdev) > +void inquiry_cache_flush(struct hci_dev *hdev) > { > struct discovery_state *cache = &hdev->discovery; > struct inquiry_entry *p, *n; Making this public means that you also have to prefix it with hci_. Johan