From: Gustavo Padovan <gustavo@padovan.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Fix sending write_le_host_supporte for LE-only controllers
Date: Tue, 23 Apr 2013 20:22:33 -0300 [thread overview]
Message-ID: <20130423232233.GA1697@joana> (raw)
In-Reply-To: <1366385721-4558-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
* Johan Hedberg <johan.hedberg@gmail.com> [2013-04-19 18:35:21 +0300]:
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> The Bluetooth Core Specification (4.0) defines the Write LE Host
> Supported HCI command as only available for controllers supporting
> BR/EDR. This is further reflected in the Read Local Extended Features
> HCI command also not being available for LE-only controllers. In other
> words, host-side LE support is implicit for single-mode LE controllers
> and doesn't have explicit HCI-level enablement.
>
> This patch ensures that the LE setting is always exposed as enabled
> through mgmt and returns a "rejected" response if user space tries to
> toggle the setting. The patch also ensures that Write LE Host Supported
> is never sent for LE-only controllers.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> v2: Instead of requiring user space to explicitly enable the setting it
> is now always enabled and trying to toggle it through mgmt will cause a
> rejected error. One missing check for bredr_supported in the HCI init
> sequence was also added.
>
> net/bluetooth/hci_core.c | 10 ++++++++++
> net/bluetooth/mgmt.c | 8 +++++++-
> 2 files changed, 17 insertions(+), 1 deletion(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
prev parent reply other threads:[~2013-04-23 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 15:35 [PATCH v2] Bluetooth: Fix sending write_le_host_supporte for LE-only controllers Johan Hedberg
2013-04-23 23:22 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423232233.GA1697@joana \
--to=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox