From: Johan Hedberg <johan.hedberg@gmail.com>
To: Alex Deymo <deymo@chromium.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
keybuk@chromium.org
Subject: Re: [PATCH v3 7/8] core: Expose the last bonding attempt timeout on retry
Date: Wed, 24 Apr 2013 14:37:18 +0300 [thread overview]
Message-ID: <20130424113718.GD15231@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1366740247-368-8-git-send-email-deymo@chromium.org>
Hi Alex,
On Tue, Apr 23, 2013, Alex Deymo wrote:
> + gint64 attempt_start_time_us;
> + gint64 last_attempt_duration_us;
> };
>
> typedef enum {
> @@ -1420,12 +1422,52 @@ static struct bonding_req *bonding_request_new(DBusMessage *msg,
>
> bonding->capability = io_cap;
>
> + /* Marks the bonding start time for the first attempt on request
> + * construction. The following attempts will be updated on
> + * device_bonding_retry. */
> + bonding->attempt_start_time_us = g_get_monotonic_time();
Since we're in the long run aiming to remove the GLib dependency, I'm
not so sure it's the best idea to add yet another dependency to a GLib
feature. Would it be that much more complicated to just use libc
directly for this? OTOH, if Marcel doesn't mind this new GLib API
dependency I'm not gonna object to this patch.
Johan
next prev parent reply other threads:[~2013-04-24 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 18:03 [PATCH v3 0/8] Autopair plugin Alex Deymo
2013-04-23 18:04 ` [PATCH v3 1/8] core: Convert the pincode callback to an interable list Alex Deymo
2013-04-24 11:24 ` Johan Hedberg
2013-04-24 11:42 ` Johan Hedberg
2013-04-23 18:04 ` [PATCH v3 2/8] plugins: Extend the pin code callback with the call number Alex Deymo
2013-04-23 18:04 ` [PATCH v3 3/8] core: Add support for retrying a bonding Alex Deymo
2013-04-24 11:29 ` Johan Hedberg
2013-04-23 18:04 ` [PATCH v3 4/8] core: retry bonding attempt until the iterator reaches the end Alex Deymo
2013-04-24 11:32 ` Johan Hedberg
2013-04-23 18:04 ` [PATCH v3 5/8] core: Add device_get_class to the public interface Alex Deymo
2013-04-23 18:04 ` [PATCH v3 6/8] autopair: Add the autopair plugin Alex Deymo
2013-04-23 18:04 ` [PATCH v3 7/8] core: Expose the last bonding attempt timeout on retry Alex Deymo
2013-04-24 11:37 ` Johan Hedberg [this message]
2013-04-24 14:03 ` Marcel Holtmann
2013-04-23 18:04 ` [PATCH v3 8/8] autopair: Try a fixed pincode for keyboards rejecting random codes Alex Deymo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424113718.GD15231@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=deymo@chromium.org \
--cc=keybuk@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox