From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2] Bluetooth: Fix not sending link key negative reply
Date: Tue, 7 May 2013 14:14:36 +0300 [thread overview]
Message-ID: <20130507111436.GA11154@x220> (raw)
In-Reply-To: <1367923915-6421-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Tue, May 07, 2013, Andrei Emeltchenko wrote:
> If Link Keys are not loaded during initialization with
> MGMT_OP_LOAD_LINK_KEYS command then pairing always fails
> since HCI_LINK_KEYS is not set. Check instead for HCI_MGMT
> flag.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> *v2 modified patch following Johan's comments
The existing behavior is intentional with the implicit assumption that a
mgmt_load_link_keys will always be received, if only to set the debug
keys flag in case of no link keys. So I'd word the commit message
differently, something like:
Bluetooth: Use HCI_MGMT flag for link keys management
The HCI_MGMT flag should be enough to test for a user space that
expects the kernel to do link keys management. Checking for the
special HCI_LINK_KEYS flag is a bit overkill for this since we
don't strictly speaking need to receive the load_link_keys
command to know that user space talks mgmt - any mgmt command
should be enough.
Johan
next prev parent reply other threads:[~2013-05-07 11:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 13:50 [RFC] Bluetooth: Fix not sending link key negative reply Andrei Emeltchenko
2013-05-07 6:06 ` Johan Hedberg
2013-05-07 10:51 ` [PATCHv2] " Andrei Emeltchenko
2013-05-07 11:14 ` Johan Hedberg [this message]
2013-05-07 11:35 ` [PATCH 1/2] Bluetooth: Use HCI_MGMT flag for link keys management Andrei Emeltchenko
2013-05-07 11:35 ` [PATCH 2/2] Bluetooth: Use HCI_MGMT instead of HCI_LINK_KEYS flag Andrei Emeltchenko
2013-05-07 11:41 ` Johan Hedberg
2013-05-07 11:57 ` [PATCH] " Andrei Emeltchenko
2013-05-14 8:44 ` [PATCHv2 1/2] " Andrei Emeltchenko
2013-05-14 8:44 ` [PATCHv2 2/2] Bluetooth: Remove unneeded flag Andrei Emeltchenko
2013-05-14 9:03 ` Johan Hedberg
2013-05-20 20:59 ` Gustavo Padovan
2013-05-20 21:44 ` Gustavo Padovan
2013-05-14 9:02 ` [PATCHv2 1/2] Bluetooth: Use HCI_MGMT instead of HCI_LINK_KEYS flag Johan Hedberg
2013-05-20 20:58 ` Gustavo Padovan
2013-05-07 12:51 ` [PATCHv2] Bluetooth: Fix not sending link key negative reply Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507111436.GA11154@x220 \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).