* [PATCH 1/1] profile: Fix incoming connections without SDP record
@ 2013-05-21 15:26 Christian Fetzer
2013-05-21 16:46 ` Mikel Astiz
2013-05-22 19:31 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Christian Fetzer @ 2013-05-21 15:26 UTC (permalink / raw)
To: linux-bluetooth
From: Christian Fetzer <christian.fetzer@bmw-carit.de>
After commit 7bd3626b6715ac6a117d56b95b455960f7cf34de, incoming connections
require the service being available from SDP. This is not always guaranteed
because some services might not be listed in SDP (like MNS).
---
src/profile.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/profile.c b/src/profile.c
index 8fd0424..9f98d65 100644
--- a/src/profile.c
+++ b/src/profile.c
@@ -1056,6 +1056,7 @@ static struct ext_io *create_conn(struct ext_io *server, GIOChannel *io,
return NULL;
}
+ btd_device_add_uuid(device, server->ext->remote_uuid);
service = btd_device_get_service(device, server->ext->remote_uuid);
if (service == NULL) {
ba2str(dst, addr);
--
1.8.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] profile: Fix incoming connections without SDP record
2013-05-21 15:26 [PATCH 1/1] profile: Fix incoming connections without SDP record Christian Fetzer
@ 2013-05-21 16:46 ` Mikel Astiz
2013-05-22 19:31 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Mikel Astiz @ 2013-05-21 16:46 UTC (permalink / raw)
To: Christian Fetzer; +Cc: linux-bluetooth
Hi Christian,
On Tue, May 21, 2013 at 5:26 PM, Christian Fetzer
<christian.fetzer@oss.bmw-carit.de> wrote:
> From: Christian Fetzer <christian.fetzer@bmw-carit.de>
>
> After commit 7bd3626b6715ac6a117d56b95b455960f7cf34de, incoming connections
> require the service being available from SDP. This is not always guaranteed
> because some services might not be listed in SDP (like MNS).
> ---
> src/profile.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/profile.c b/src/profile.c
> index 8fd0424..9f98d65 100644
> --- a/src/profile.c
> +++ b/src/profile.c
> @@ -1056,6 +1056,7 @@ static struct ext_io *create_conn(struct ext_io *server, GIOChannel *io,
> return NULL;
> }
>
> + btd_device_add_uuid(device, server->ext->remote_uuid);
> service = btd_device_get_service(device, server->ext->remote_uuid);
> if (service == NULL) {
> ba2str(dst, addr);
> --
Ack from my side.
A comment might be helpful to clarify that the condition below (i.e.
service == NULL) is now unlikely and only possible due to issues
during profile probe.
Cheers,
Mikel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] profile: Fix incoming connections without SDP record
2013-05-21 15:26 [PATCH 1/1] profile: Fix incoming connections without SDP record Christian Fetzer
2013-05-21 16:46 ` Mikel Astiz
@ 2013-05-22 19:31 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2013-05-22 19:31 UTC (permalink / raw)
To: Christian Fetzer; +Cc: linux-bluetooth
Hi Christian,
On Tue, May 21, 2013, Christian Fetzer wrote:
> After commit 7bd3626b6715ac6a117d56b95b455960f7cf34de, incoming
> connections require the service being available from SDP. This is not
> always guaranteed because some services might not be listed in SDP
> (like MNS).
> ---
> src/profile.c | 1 +
> 1 file changed, 1 insertion(+)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-22 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-21 15:26 [PATCH 1/1] profile: Fix incoming connections without SDP record Christian Fetzer
2013-05-21 16:46 ` Mikel Astiz
2013-05-22 19:31 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).