linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btmrvl: fix error return code in btmrvl_sdio_card_to_host()
@ 2013-06-05  2:16 Wei Yongjun
  2013-06-05 15:53 ` Gustavo Padovan
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-06-05  2:16 UTC (permalink / raw)
  To: marcel, gustavo, johan.hedberg; +Cc: yongjun_wei, linux-bluetooth

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fix to return -ENOMEM in the skb alloc error handling case
instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/bluetooth/btmrvl_sdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 13693b7..75c2626 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -554,6 +554,7 @@ static int btmrvl_sdio_card_to_host(struct btmrvl_private *priv)
 	skb = bt_skb_alloc(num_blocks * blksz + BTSDIO_DMA_ALIGN, GFP_ATOMIC);
 	if (skb == NULL) {
 		BT_ERR("No free skb");
+		ret = -ENOMEM;
 		goto exit;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: btmrvl: fix error return code in btmrvl_sdio_card_to_host()
  2013-06-05  2:16 [PATCH] Bluetooth: btmrvl: fix error return code in btmrvl_sdio_card_to_host() Wei Yongjun
@ 2013-06-05 15:53 ` Gustavo Padovan
  0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2013-06-05 15:53 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: marcel, johan.hedberg, yongjun_wei, linux-bluetooth

Hi Wei,

* Wei Yongjun <weiyj.lk@gmail.com> [2013-06-05 10:16:55 +0800]:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return -ENOMEM in the skb alloc error handling case
> instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/bluetooth/btmrvl_sdio.c | 1 +
>  1 file changed, 1 insertion(+)

Patch has been applied to bluetooth.git. Thanks.

	Gustavo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-05 15:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05  2:16 [PATCH] Bluetooth: btmrvl: fix error return code in btmrvl_sdio_card_to_host() Wei Yongjun
2013-06-05 15:53 ` Gustavo Padovan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).