linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bruna Moreira <bruna.moreira@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org,
	Jefferson Delfes <jefferson.delfes@openbossa.org>
Subject: Re: [RFC BlueZ 05/35] emulator: Search virtual devices in LE advertising mode
Date: Wed, 19 Jun 2013 12:56:30 +0300	[thread overview]
Message-ID: <20130619095630.GA6370@x220> (raw)
In-Reply-To: <1371041841-21793-6-git-send-email-bruna.moreira@openbossa.org>

Hi,

On Wed, Jun 12, 2013, Bruna Moreira wrote:
> From: Jefferson Delfes <jefferson.delfes@openbossa.org>
> 
> After LE scan is enabled, the emulator search virtual devices that are
> in advertising mode, in order to copy adv data.
> ---
>  emulator/btdev.c |   15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index a7af6b3..160e5bf 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -876,6 +876,19 @@ static void remote_version_complete(struct btdev *btdev, uint16_t handle)
>  							&rvc, sizeof(rvc));
>  }
>  
> +static void le_set_scan_enable_complete(struct btdev *btdev)
> +{
> +	int i;
> +
> +	for (i = 0; i < MAX_BTDEV_ENTRIES; i++) {
> +		if (!btdev_list[i] || btdev_list[i] == btdev)
> +			continue;
> +
> +		if (!btdev_list[i]->le_adv_enable)
> +			continue;
> +	}
> +}

What's the purpose of this function? It doesn't seem to do anything but
iterate through the btdev list. Should it be merged with some later
patch (which actually does something useful)?

Johan

  reply	other threads:[~2013-06-19  9:56 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 12:56 [RFC BlueZ 00/35] More discovery tests Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 01/35] emulator: Add support for multiple connections Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 02/35] emulator: Store LE advertising data length in btdev Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 03/35] emulator: Implement basic LE set adv enable command Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 04/35] emulator: Store LE scan state of virtual controller Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 05/35] emulator: Search virtual devices in LE advertising mode Bruna Moreira
2013-06-19  9:56   ` Johan Hedberg [this message]
2013-06-20 11:49     ` Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 06/35] emulator: Search virtual devices in LE scan mode Bruna Moreira
2013-06-19  9:57   ` Johan Hedberg
2013-06-20 11:52     ` Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 07/35] emulator: Implement LE advertising report Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 08/35] emulator: Implement basic LE create connection Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 09/35] emulator: Dummy LE set advertising parameters Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 10/35] emulator: Disallow LE set scan params command when scan is enabled Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 11/35] emulator: Set LE supported states Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 12/35] emulator: Add remove operation in HCI hook callback Bruna Moreira
2013-06-12 12:56 ` [RFC BlueZ 13/35] emulator: Add support for pre/post command/event hooks Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 14/35] emulator: Add hook only if there aren't other with same type and opcode Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 15/35] emulator: Export command and event hooks for hciemu user Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 16/35] emulator: Add support for delete a hook Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 17/35] emulator: Split default_cmd() for better command and event handler Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 18/35] emulator: cmd_status() using send_packet() for run hooks easily Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 19/35] emulator: Add new function for running all hooks Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 20/35] tools/mgmt-tester: Add stop discovery for BR/EDR only Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 21/35] tools/mgmt-tester: Add support for second controller Bruna Moreira
2013-06-19 10:00   ` Johan Hedberg
2013-06-12 12:57 ` [RFC BlueZ 22/35] tools/mgmt-tester: BR/EDR Start discovery (Device Found) Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 23/35] tools/mgmt-tester: LE only " Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 24/35] tools/mgmt-tester: Split test_command_generic() Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 25/35] tools/mgmt-tester: BR/EDR Stop discovery (Device Found) Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 26/35] btdev: Add function to send an aborted packet Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 27/35] emulator: Fix Remote Name Request Cancel command complete Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 28/35] tools/mgmt-tester: Move command_generic_callback() Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 29/35] tools/mgmt-tester: BR/EDR Stop discovery (Name Resolving) Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 30/35] tools/mgmt-tester: Add support to set emulator type Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 31/35] tools/mgmt-tester: LE Stop discovery (Device Found) Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 32/35] tools/mgmt-tester: Interleaved stop discovery (LE dev. found) Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 33/35] tools/mgmt-tester: Increase timeout for dual mode controller Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 34/35] tools/mgmt-tester: Interleaved stop discovery (BR/EDR dev. found) Bruna Moreira
2013-06-12 12:57 ` [RFC BlueZ 35/35] tools/mgmt-tester: Interleaved Stop discovery (Name Resolving) Bruna Moreira
2013-06-19 10:02 ` [RFC BlueZ 00/35] More discovery tests Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130619095630.GA6370@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=bruna.moreira@openbossa.org \
    --cc=jefferson.delfes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).