Linux bluetooth development
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix getting SCO socket options in deferred state
Date: Thu, 15 Aug 2013 10:08:13 +0200	[thread overview]
Message-ID: <20130815080813.GB1980@joana> (raw)
In-Reply-To: <1375962836-3050-1-git-send-email-johan.hedberg@gmail.com>

Hi Johan,

* johan.hedberg@gmail.com <johan.hedberg@gmail.com> [2013-08-08 14:53:56 +0300]:

> From: Johan Hedberg <johan.hedberg@intel.com>
> 
> When a socket is in deferred state there does actually exist an
> underlying connection even though the connection state is not yet
> BT_CONNECTED. In the deferred state it should therefore be allowed to
> get socket options that usually depend on a connection, such as
> SCO_OPTIONS and SCO_CONNINFO.
> 
> This patch fixes the behavior of some user space code that behaves as
> follows without it:
> 
> $ sudo tools/btiotest -i 00:1B:DC:xx:xx:xx -d -s
> accept=2 reject=-1 discon=-1 defer=1 sec=0 update_sec=0 prio=0 voice=0x0000
> Listening for SCO connections
> bt_io_get(OPT_DEST): getsockopt(SCO_OPTIONS): Transport endpoint is not connected (107)
> Accepting connection
> Successfully connected to 60:D8:19:xx:xx:xx. handle=43, class=000000
> 
> The conditions that the patch updates the if-statements to is taken from
> similar code in l2cap_sock.c which correctly handles the deferred state.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
>  net/bluetooth/sco.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Patch has been applied to bluetooth-next. Thanks.

	Gustavo

      reply	other threads:[~2013-08-15  8:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 11:53 [PATCH] Bluetooth: Fix getting SCO socket options in deferred state johan.hedberg
2013-08-15  8:08 ` Gustavo Padovan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815080813.GB1980@joana \
    --to=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox