Linux bluetooth development
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Bluetooth regression in 3.10
Date: Wed, 4 Sep 2013 15:53:18 +0200	[thread overview]
Message-ID: <20130904155318.21cb6f37@milhouse> (raw)

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

Hi Johan,

I noticed the thread "3.10-rc: bluetooth disappeared on thinkpad x60 (regression)"
on lkml, but unfortunately the resulting patch does not fix the regression
for me.
I'm running 3.10.10, so the fix from the thread is applied to my kernel.

I see similar issues when trying to bring up my Bluetooth dongle:

$ lsusb | grep Blue
Bus 004 Device 002: ID 0a12:0001 Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode)

This is a Broadcom chip based device.

$ hciconfig hci0 up                                            
Can't init device hci0: Operation not supported (95)

hcidump hci0 -X shows:

< HCI Command: Delete Stored Link Key (0x03|0x0012) plen 7
    bdaddr 00:00:00:00:00:00 all 1
> HCI Event: Command Complete (0x0e) plen 4
    Delete Stored Link Key (0x03|0x0012) ncmd 1
    status 0x11 deleted 0
    Error: Unsupported Feature or Parameter Value
device: disconnected


The following workaround fixes the problem for me:

Index: linux/net/bluetooth/hci_core.c
===================================================================
--- linux.orig/net/bluetooth/hci_core.c	2013-07-21 17:34:22.749435335 +0200
+++ linux/net/bluetooth/hci_core.c	2013-09-04 15:39:07.580170034 +0200
@@ -598,7 +598,7 @@
 	u8 p;
 
 	/* Only send HCI_Delete_Stored_Link_Key if it is supported */
-	if (hdev->commands[6] & 0x80) {
+	if (0) {
 		struct hci_cp_delete_stored_link_key cp;
 
 		bacpy(&cp.bdaddr, BDADDR_ANY);


This isn't a real solution, of course.
I would be happy to test alternative solutions.

-- 
Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2013-09-04 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 13:53 Michael Büsch [this message]
2013-09-04 15:40 ` Bluetooth regression in 3.10 Marcel Holtmann
2013-09-04 16:14   ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904155318.21cb6f37@milhouse \
    --to=m@bues.ch \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox