linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] Bluetooth: Disable upper layer connections when user channel is active
@ 2013-09-04  1:08 Marcel Holtmann
  2013-09-06  9:06 ` Johan Hedberg
  2013-09-10 15:47 ` Gustavo Padovan
  0 siblings, 2 replies; 3+ messages in thread
From: Marcel Holtmann @ 2013-09-04  1:08 UTC (permalink / raw)
  To: linux-bluetooth

When the device has the user channel flag set, it means it is driven by
an user application. In that case do not allow any connections from
L2CAP or SCO sockets.

This is the same situation as when the device has the raw flag set and
it will then return EHOSTUNREACH.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 net/bluetooth/hci_conn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index f081712..d2380e0 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -518,6 +518,7 @@ struct hci_dev *hci_get_route(bdaddr_t *dst, bdaddr_t *src)
 	list_for_each_entry(d, &hci_dev_list, list) {
 		if (!test_bit(HCI_UP, &d->flags) ||
 		    test_bit(HCI_RAW, &d->flags) ||
+		    test_bit(HCI_USER_CHANNEL, &d->dev_flags) ||
 		    d->dev_type != HCI_BREDR)
 			continue;
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Bluetooth: Disable upper layer connections when user channel is active
  2013-09-04  1:08 [PATCH 1/2] Bluetooth: Disable upper layer connections when user channel is active Marcel Holtmann
@ 2013-09-06  9:06 ` Johan Hedberg
  2013-09-10 15:47 ` Gustavo Padovan
  1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2013-09-06  9:06 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth

Hi Marcel,

On Tue, Sep 03, 2013, Marcel Holtmann wrote:
> When the device has the user channel flag set, it means it is driven by
> an user application. In that case do not allow any connections from
> L2CAP or SCO sockets.
> 
> This is the same situation as when the device has the raw flag set and
> it will then return EHOSTUNREACH.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/bluetooth/hci_conn.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Johan Hedberg <johan.hedberg@intel.com>

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Bluetooth: Disable upper layer connections when user channel is active
  2013-09-04  1:08 [PATCH 1/2] Bluetooth: Disable upper layer connections when user channel is active Marcel Holtmann
  2013-09-06  9:06 ` Johan Hedberg
@ 2013-09-10 15:47 ` Gustavo Padovan
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2013-09-10 15:47 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth

Hi Marcel,

2013-09-03 Marcel Holtmann <marcel@holtmann.org>:

> When the device has the user channel flag set, it means it is driven by
> an user application. In that case do not allow any connections from
> L2CAP or SCO sockets.
> 
> This is the same situation as when the device has the raw flag set and
> it will then return EHOSTUNREACH.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/bluetooth/hci_conn.c | 1 +
>  1 file changed, 1 insertion(+)

Patch has been applied to bluetooth-next. Thanks.

	Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-10 15:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04  1:08 [PATCH 1/2] Bluetooth: Disable upper layer connections when user channel is active Marcel Holtmann
2013-09-06  9:06 ` Johan Hedberg
2013-09-10 15:47 ` Gustavo Padovan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).