linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v5 8/8] Bluetooth: Fix waiting for clearing of BT_SK_SUSPEND flag
Date: Wed, 18 Sep 2013 17:04:17 -0500	[thread overview]
Message-ID: <20130918220417.GC4006@joana> (raw)
In-Reply-To: <1379325919-19003-9-git-send-email-johan.hedberg@gmail.com>

Hi Johan,

2013-09-16 johan.hedberg@gmail.com <johan.hedberg@gmail.com>:

> From: Johan Hedberg <johan.hedberg@intel.com>
> 
> In the case of blocking sockets we should not proceed with sendmsg() if
> the socket has the BT_SK_SUSPEND flag set. So far the code was only
> ensuring that POLLOUT doesn't get set for non-blocking sockets using
> poll() but there was no code in place to ensure that blocking sockets do
> the right thing when writing to them.
> 
> This patch adds a new bt_sock_wait_ready helper function to sleep in the
> sendmsg call if the BT_SK_SUSPEND flag is set, and wake up as soon as it
> is unset. It also updates the L2CAP and RFCOMM sendmsg callbacks to take
> advantage of this new helper function.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
>  include/net/bluetooth/bluetooth.h |  1 +
>  net/bluetooth/af_bluetooth.c      | 40 +++++++++++++++++++++++++++++++++++++++
>  net/bluetooth/l2cap_sock.c        |  6 ++++++
>  net/bluetooth/rfcomm/sock.c       |  7 ++++++-
>  4 files changed, 53 insertions(+), 1 deletion(-)

All patches have been applied to bluetooth-next. Thanks.

	Gustavo

      parent reply	other threads:[~2013-09-18 22:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16 10:05 [PATCH v5 0/8] Bluetooth: Various L2CAP fixes johan.hedberg
2013-09-16 10:05 ` [PATCH v5 1/8] Bluetooth: Remove unused event mask struct johan.hedberg
2013-09-16 10:05 ` [PATCH v5 2/8] Bluetooth: Fix double error response for l2cap_create_chan_req johan.hedberg
2013-09-16 10:05 ` [PATCH v5 3/8] Bluetooth: Fix L2CAP error return used for failed channel lookups johan.hedberg
2013-09-16 14:12   ` Marcel Holtmann
2013-09-16 10:05 ` [PATCH v5 4/8] Bluetooth: Fix L2CAP Disconnect response for unknown CID johan.hedberg
2013-09-16 14:10   ` Marcel Holtmann
2013-09-16 10:05 ` [PATCH v5 5/8] Bluetooth: Fix L2CAP command reject reason johan.hedberg
2013-09-16 14:11   ` Marcel Holtmann
2013-09-16 10:05 ` [PATCH v5 6/8] Bluetooth: Fix sending responses to identified L2CAP response packets johan.hedberg
2013-09-16 10:05 ` [PATCH v5 7/8] Bluetooth: Fix responding to invalid L2CAP signaling commands johan.hedberg
2013-09-16 10:05 ` [PATCH v5 8/8] Bluetooth: Fix waiting for clearing of BT_SK_SUSPEND flag johan.hedberg
2013-09-16 14:13   ` Marcel Holtmann
2013-09-18 22:04   ` Gustavo Padovan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130918220417.GC4006@joana \
    --to=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).