From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] Bluetooth: Provide high speed configuration option
Date: Mon, 30 Sep 2013 12:18:58 +0300 [thread overview]
Message-ID: <20130930091820.GH10262@aemeltch-MOBL1> (raw)
In-Reply-To: <1380514261-21742-3-git-send-email-marcel@holtmann.org>
Hi Marcel,
On Sun, Sep 29, 2013 at 09:11:01PM -0700, Marcel Holtmann wrote:
> Hiding the Bluetooth high speed support behind a module parameter is
> not really useful. This can be enabled and disabled at runtime via
> the management interface. This also has the advantage that his can
typo here.
...
> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> index c85537c..9119898 100644
> --- a/net/bluetooth/l2cap_sock.c
> +++ b/net/bluetooth/l2cap_sock.c
> @@ -445,11 +445,6 @@ static int l2cap_sock_getsockopt(struct socket *sock, int level, int optname,
> break;
>
> case BT_CHANNEL_POLICY:
> - if (!enable_hs) {
> - err = -ENOPROTOOPT;
> - break;
> - }
> -
Do you think we don't need to check that HS is enabled here and below?
> if (put_user(chan->chan_policy, (u32 __user *) optval))
> err = -EFAULT;
> break;
> @@ -720,11 +715,6 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname,
> break;
>
> case BT_CHANNEL_POLICY:
> - if (!enable_hs) {
> - err = -ENOPROTOOPT;
> - break;
> - }
> -
> if (get_user(opt, (u32 __user *) optval)) {
> err = -EFAULT;
> break;
...
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2013-09-30 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 4:11 [PATCH 3/3] Bluetooth: Provide high speed configuration option Marcel Holtmann
2013-09-30 9:18 ` Andrei Emeltchenko [this message]
2013-09-30 9:23 ` Marcel Holtmann
2013-09-30 18:15 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930091820.GH10262@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox