From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Frederic Danis <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4 5/7] android: Android version of log.c
Date: Fri, 4 Oct 2013 11:16:14 +0300 [thread overview]
Message-ID: <20131004081612.GE2804@aemeltch-MOBL1> (raw)
In-Reply-To: <1380632319-7701-5-git-send-email-frederic.danis@linux.intel.com>
On Tue, Oct 01, 2013 at 02:58:37PM +0200, Frederic Danis wrote:
> ---
> android/log.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> android/main.c | 34 +++++++++++
> 2 files changed, 206 insertions(+)
> create mode 100644 android/log.c
What is the status with review. Do I understand correctly that it needs to
be changed something like:
void info(const char *format, ...)
{
va_list ap;
va_start(ap, format);
- android_log(LOG_INFO, format, ap);
+ vfprintf(stderr, format, ap);
+ fprintf(stderr, "\n");
va_end(ap);
}
If so I can change this myself and resend patch series.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2013-10-04 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 12:58 [PATCH v4 1/7] build: Add skeleton for BlueZ Android Frederic Danis
2013-10-01 12:58 ` [PATCH v4 2/7] android: Add skeleton of BlueZ Android daemon Frederic Danis
2013-10-01 12:58 ` [PATCH v4 3/7] android-build: Add " Frederic Danis
2013-10-01 12:58 ` [PATCH v4 4/7] build: " Frederic Danis
2013-10-01 12:58 ` [PATCH v4 5/7] android: Android version of log.c Frederic Danis
2013-10-04 8:16 ` Andrei Emeltchenko [this message]
2013-10-01 12:58 ` [PATCH v4 6/7] android-build: Add logging system Frederic Danis
2013-10-01 12:58 ` [PATCH v4 7/7] build: " Frederic Danis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004081612.GE2804@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox