From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv3 01/15] android: Supress missing initializers warnings
Date: Thu, 10 Oct 2013 09:58:27 +0300 [thread overview]
Message-ID: <20131010065825.GC23879@aemeltch-MOBL1> (raw)
In-Reply-To: <E4E245F7-8EE6-4FE2-AC99-3246F1541C99@holtmann.org>
Hi Marcel,
On Wed, Oct 09, 2013 at 09:11:04PM +0200, Marcel Holtmann wrote:
> Hi Andrei,
>
> > These types of warnings are disabled in BlueZ makeifiles
> >
> > main.c:67:2: warning: missing initializer [-Wmissing-field-initializers]
> > main.c:67:2: warning: (near initialization for 'options[1].short_name')
> > [-Wmissing-field-initializers]
> > ---
> > android/Android.mk | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/android/Android.mk b/android/Android.mk
> > index ec820ac..5498b41 100644
> > --- a/android/Android.mk
> > +++ b/android/Android.mk
> > @@ -23,6 +23,9 @@ LOCAL_C_INCLUDES := \
> >
> > LOCAL_CFLAGS := -DVERSION=\"$(BLUEZ_VERSION)\"
> >
> > +# to suppress the "warning: missing initializer near initialization.." warning
> > +LOCAL_CFLAGS += -Wno-missing-field-initializers
> > +
>
> why are we doing this and not fixing the actual warning?
>
Do you want me to initialize structures like
{NULL, NULL, NULL, ... }
this way it can be fixed.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2013-10-10 6:58 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 7:38 [PATCHv1 00/15] Basic code for Android BlueZ Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 01/15] android: Supress missing initializers warnings Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 02/15] android: Add Adapter Bluetooth HAL template Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 03/15] android: Add Socket " Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 04/15] android: Enable Socket interface Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 05/15] android: Start Android Bluetooth daemon Andrei Emeltchenko
2013-10-07 12:09 ` Szymon Janc
2013-10-07 7:38 ` [PATCHv1 06/15] android: Add basic mgmt initialization sequence Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 07/15] android: Create HAL API header skeleton Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 08/15] android: Add adapter and device struct for BlueZ daemon Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 09/15] android: Add Android Makefile for libbluetooth Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 10/15] android: sdp: Reuse BlueZ SDP server in Android Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 11/15] android: Add cap to bind to port < 1024 Andrei Emeltchenko
2013-10-07 12:14 ` Szymon Janc
2013-10-07 7:38 ` [PATCHv1 12/15] android: Implement read_info_complete callback Andrei Emeltchenko
2013-10-07 12:26 ` Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 13/15] android: Handle mgmt changed events Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 14/15] android: Add makefile for hciconfig Andrei Emeltchenko
2013-10-07 7:38 ` [PATCHv1 15/15] android: Add makefile for hcitool Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 00/15] Basic code for Android BlueZ Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 01/15] android: Supress missing initializers warnings Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 02/15] android: Add Adapter Bluetooth HAL template Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 03/15] android: Add Socket " Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 04/15] android: Enable Socket interface Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 05/15] android: Start Android Bluetooth daemon Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 06/15] android: Add basic mgmt initialization sequence Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 07/15] android: Create HAL API header skeleton Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 08/15] android: Add adapter and device struct for BlueZ daemon Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 09/15] android: Add Android Makefile for libbluetooth Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 10/15] android: sdp: Reuse BlueZ SDP server in Android Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 11/15] android: Add cap to bind to port < 1024 Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 12/15] android: Implement read_info_complete callback Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 13/15] android: Handle mgmt changed events Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 14/15] android: Add makefile for hciconfig Andrei Emeltchenko
2013-10-08 10:33 ` [PATCHv2 15/15] android: Add makefile for hcitool Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 00/15] Basic code for Android BlueZ Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 01/15] android: Supress missing initializers warnings Andrei Emeltchenko
2013-10-09 19:11 ` Marcel Holtmann
2013-10-09 22:55 ` Lucas De Marchi
2013-10-10 6:58 ` Andrei Emeltchenko [this message]
2013-10-10 7:35 ` Marcel Holtmann
2013-10-10 8:07 ` Andrei Emeltchenko
2013-10-10 8:10 ` Marcel Holtmann
2013-10-10 8:16 ` Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 02/15] android: Add Adapter Bluetooth HAL template Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 03/15] android: Add Socket " Andrei Emeltchenko
2013-10-09 19:14 ` Marcel Holtmann
2013-10-10 6:56 ` Andrei Emeltchenko
2013-10-10 7:33 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 04/15] android: Enable Socket interface Andrei Emeltchenko
2013-10-09 19:15 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 05/15] android: Start Android Bluetooth daemon Andrei Emeltchenko
2013-10-09 19:19 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 06/15] android: Add basic mgmt initialization sequence Andrei Emeltchenko
2013-10-09 19:30 ` Marcel Holtmann
2013-10-10 9:59 ` Andrei Emeltchenko
2013-10-10 12:38 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 07/15] android: Create HAL API header skeleton Andrei Emeltchenko
2013-10-09 19:34 ` Marcel Holtmann
2013-10-10 12:29 ` Andrei Emeltchenko
2013-10-10 12:35 ` Marcel Holtmann
2013-10-10 12:48 ` Andrei Emeltchenko
2013-10-10 13:02 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 08/15] android: Add adapter and device struct for BlueZ daemon Andrei Emeltchenko
2013-10-09 19:39 ` Marcel Holtmann
2013-10-10 12:36 ` Andrei Emeltchenko
2013-10-10 12:40 ` Marcel Holtmann
2013-10-10 9:07 ` Marcin Kraglak
2013-10-10 12:30 ` Andrei Emeltchenko
2013-10-10 13:18 ` Marcin Kraglak
2013-10-10 13:27 ` Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 09/15] android: Add Android Makefile for libbluetooth Andrei Emeltchenko
2013-10-09 19:43 ` Marcel Holtmann
2013-10-10 12:43 ` Andrei Emeltchenko
2013-10-10 12:45 ` Marcel Holtmann
2013-10-10 12:52 ` Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 10/15] android: sdp: Reuse BlueZ SDP server in Android Andrei Emeltchenko
2013-10-09 19:45 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 11/15] android: Add cap to bind to port < 1024 Andrei Emeltchenko
2013-10-09 19:48 ` Marcel Holtmann
2013-10-10 13:01 ` Andrei Emeltchenko
2013-10-08 14:51 ` [PATCHv3 12/15] android: Implement read_info_complete callback Andrei Emeltchenko
2013-10-09 19:54 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 13/15] android: Handle mgmt changed events Andrei Emeltchenko
2013-10-09 19:58 ` Marcel Holtmann
2013-10-08 14:51 ` [PATCHv3 14/15] android: Add makefile for hciconfig Andrei Emeltchenko
2013-10-09 19:59 ` Marcel Holtmann
2013-10-14 11:51 ` Andrei Emeltchenko
2013-10-14 12:06 ` Marcel Holtmann
2013-10-14 13:39 ` Michal Labedzki
2013-10-08 14:51 ` [PATCHv3 15/15] android: Add makefile for hcitool Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010065825.GC23879@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox