From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 16 Oct 2013 11:54:47 +0300 From: Andrei Emeltchenko To: johan.hedberg@gmail.com Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH 1/2] Bluetooth: Ignore A2MP data on non-BR/EDR links Message-ID: <20131016085445.GL2861@aemeltch-MOBL1> References: <1381912621-10238-1-git-send-email-johan.hedberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1381912621-10238-1-git-send-email-johan.hedberg@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, On Wed, Oct 16, 2013 at 11:37:00AM +0300, johan.hedberg@gmail.com wrote: > From: Johan Hedberg > > The A2MP CID is only valid for BR/EDR transports. We should ignore A2MP > data on non-BR/EDR links and refuse to create an amp_mgr object. > > Signed-off-by: Johan Hedberg > --- > net/bluetooth/a2mp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c > index fe32a33..efcd108 100644 > --- a/net/bluetooth/a2mp.c > +++ b/net/bluetooth/a2mp.c > @@ -836,6 +836,9 @@ struct l2cap_chan *a2mp_channel_create(struct l2cap_conn *conn, > { > struct amp_mgr *mgr; > > + if (conn->hcon->type != ACL_LINK) > + return NULL; > + Have you experienced this ever happened? Best regards Andrei Emeltchenko