From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC 7/9] android: Fix building with local cutils/log.h
Date: Thu, 17 Oct 2013 14:20:00 +0300 [thread overview]
Message-ID: <20131017111958.GT2861@aemeltch-MOBL1> (raw)
In-Reply-To: <CAJdJm_MNvbK7XaLaapeE_rR4fTxsENjoNouBqx2eLXBOkaTfsQ@mail.gmail.com>
Hi all,
On Thu, Oct 17, 2013 at 06:57:29AM -0400, Anderson Lizardo wrote:
> Hi Luiz,
>
> On Thu, Oct 17, 2013 at 4:55 AM, Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > android/hal_bt_sock.c: In function 'btsock_listen_rfcomm':
> > android/hal_bt_sock.c:30:47: error: expected ')' before '__func__'
> > ALOGD(__func__);
>
> You can implement ALOGD() using vfprintf() (just like DBG(), but which
> uses vsyslog() instead) and avoid this commit.
I agree here, we are anyway implementing ALOGD, let's implement it
correctly.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2013-10-17 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 8:55 [RFC 0/9] Enable building HAL with autotools Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 1/9] android: Add hardware/hardware.h Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 2/9] android: Add hardware/bluetooth.h Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 3/9] android: Add hardware/bt_sock.h Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 4/9] android: Add cutils/log.h Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 5/9] android: Add cutils/properties.h Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 6/9] build: Enable building HAL as libbt-internal.la Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 7/9] android: Fix building with local cutils/log.h Luiz Augusto von Dentz
2013-10-17 10:57 ` Anderson Lizardo
2013-10-17 11:20 ` Andrei Emeltchenko [this message]
2013-10-17 8:55 ` [RFC 8/9] android: Fix build error when compiling with autotools Luiz Augusto von Dentz
2013-10-17 8:55 ` [RFC 9/9] android: Fix build error " Luiz Augusto von Dentz
2013-10-17 9:17 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017111958.GT2861@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox