From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 06/15] android/hal: Add support for sending create bond command
Date: Fri, 25 Oct 2013 12:36:17 +0300 [thread overview]
Message-ID: <20131025093616.GC6113@aemeltch-MOBL1> (raw)
In-Reply-To: <1382691378-31940-6-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
On Fri, Oct 25, 2013 at 10:56:09AM +0200, Szymon Janc wrote:
> This allows HAL to start bonding.
> ---
> android/hal-bluetooth.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c
> index b81f8dd..6f7ef45 100644
> --- a/android/hal-bluetooth.c
> +++ b/android/hal-bluetooth.c
> @@ -275,15 +275,17 @@ static int cancel_discovery(void)
>
> static int create_bond(const bt_bdaddr_t *bd_addr)
> {
> + struct hal_cmd_create_bond cmd;
> +
> DBG("");
>
> if (!interface_ready())
> return BT_STATUS_NOT_READY;
>
> - if (!bd_addr)
> - return BT_STATUS_PARM_INVALID;
I think we can leave check here
Best regards
Andrei Emeltchenko
> + memcpy(cmd.bdaddr, bd_addr, sizeof(cmd.bdaddr));
>
> - return BT_STATUS_UNSUPPORTED;
> + return hal_ipc_cmd(HAL_SERVICE_ID_BLUETOOTH, HAL_OP_CREATE_BOND,
> + sizeof(cmd), &cmd, 0, NULL, NULL);
> }
>
> static int cancel_bond(const bt_bdaddr_t *bd_addr)
> --
> 1.8.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-25 9:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 8:56 [PATCH 01/15] android: Remove not needed local variable in connect_hal Szymon Janc
2013-10-25 8:56 ` [PATCH 02/15] android: Add properties defines to hal-msg.h Szymon Janc
2013-10-25 8:56 ` [PATCH 03/15] android/hal: Add support for sending adapter set property command Szymon Janc
2013-10-25 8:56 ` [PATCH 04/15] android/hal: Add support for sending adapter get " Szymon Janc
2013-10-25 8:56 ` [PATCH 05/15] android/hal: Add support for sending adapter get properties command Szymon Janc
2013-10-25 8:56 ` [PATCH 06/15] android/hal: Add support for sending create bond command Szymon Janc
2013-10-25 9:36 ` Andrei Emeltchenko [this message]
2013-10-25 10:15 ` Luiz Augusto von Dentz
2013-10-25 8:56 ` [PATCH 07/15] android/hal: Add support for sending cancel " Szymon Janc
2013-10-25 8:56 ` [PATCH 08/15] android/hal: Add support for sending adapter remove " Szymon Janc
2013-10-25 8:56 ` [PATCH 09/15] android/hal: Add support for sending adapter PIN reply command Szymon Janc
2013-10-25 8:56 ` [PATCH 10/15] android: Add missing SSP Variant definitions to IPC document Szymon Janc
2013-10-25 8:56 ` [PATCH 11/15] android: Add missing SSP variant definitions to IPC header Szymon Janc
2013-10-25 8:56 ` [PATCH 12/15] android/hal: Add support for sending adapter SSP reply command Szymon Janc
2013-10-25 8:56 ` [PATCH 13/15] android/hal: Add support for handling adapter properties change event Szymon Janc
2013-10-25 8:56 ` [PATCH 14/15] android: Add missing success status definition to IPC header Szymon Janc
2013-10-25 8:56 ` [PATCH 15/15] android: Add initial support for handling adapter get property command Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025093616.GC6113@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox