Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2 4/6] android: Add supported uuids when adapter is initialized
Date: Thu, 7 Nov 2013 10:04:53 +0200	[thread overview]
Message-ID: <20131107080450.GA21468@aemeltch-MOBL1> (raw)
In-Reply-To: <1383657700-22313-5-git-send-email-marcin.kraglak@tieto.com>

Hi All,

On Tue, Nov 05, 2013 at 02:21:38PM +0100, Marcin Kraglak wrote:
> It will set class of device with proper service hints.
> We set it statically because we want to keep code simple.
> 
> ---
>  android/adapter.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/android/adapter.c b/android/adapter.c
> index 0f24cac..70b9265 100644
> --- a/android/adapter.c
> +++ b/android/adapter.c
> @@ -52,6 +52,29 @@ static GIOChannel *notification_io = NULL;
>  /* This list contains addresses which are asked for records */
>  static GSList *browse_reqs;
>  
> +/*
> + * This is an array of supported uuids and service hints. We add them via mgmt
> + * interface when adapter is initialized. Uuids are in reverse orded.
> + */
> +static const struct mgmt_cp_add_uuid supported_services[] = {
> +	/* OBEX_OPP_UUID */
> +	{ .uuid = { 0xfb, 0x34, 0x9b, 0x5f, 0x80, 0x00, 0x00, 0x80,
> +			0x00, 0x10, 0x00, 0x00, 0x05, 0x11, 0x00, 0x00 },
> +	.svc_hint = 0x10 },

I think PBAP is missing here. BTW can we define those strings separately
so that it might be used to compare.

Socket HAL identify service by UUID so I need to derive RFCOMM channel
from it. I am thinking simply comparing those strings.

Any opinion on this?

Best regards 
Andrei Emeltchenko 

  parent reply	other threads:[~2013-11-07  8:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 13:21 [PATCHv2 0/6] Query remote services support Marcin Kraglak
2013-11-05 13:21 ` [PATCHv2 1/6] android: Initial implementation of get_remote_services Marcin Kraglak
2013-11-05 13:21 ` [PATCHv2 2/6] android: Fetch remote device uuids after pairing Marcin Kraglak
2013-11-05 13:21 ` [PATCHv2 3/6] android: Pass found uuids to remote_device_properties_cb Marcin Kraglak
2013-11-05 13:21 ` [PATCHv2 4/6] android: Add supported uuids when adapter is initialized Marcin Kraglak
2013-11-06  8:02   ` Johan Hedberg
2013-11-06  8:27     ` Marcin Kraglak
2013-11-06  8:41     ` Marcel Holtmann
2013-11-06 11:08       ` Marcin Kraglak
2013-11-07  8:04   ` Andrei Emeltchenko [this message]
2013-11-05 13:21 ` [PATCHv2 5/6] android: Implement class of device property callback Marcin Kraglak
2013-11-05 13:21 ` [PATCHv2 6/6] android: Add support for getting adapter uuids Marcin Kraglak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131107080450.GA21468@aemeltch-MOBL1 \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcin.kraglak@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox