From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 16 Nov 2013 06:29:36 +0900 From: Greg Kroah-Hartman To: Marcel Holtmann Cc: Dan Carpenter , Geert Uytterhoeven , devel@driverdev.osuosl.org, Johan Hedberg , Yu-Chen Cho , "linux-kernel@vger.kernel.org list" , "linux-bluetooth@vger.kernel.org development" Subject: Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback Message-ID: <20131115212936.GC14897@kroah.com> References: <1384517231-1605-1-git-send-email-geert@linux-m68k.org> <20131115130820.GS5302@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Fri, Nov 15, 2013 at 10:26:41PM +0900, Marcel Holtmann wrote: > Hi Dan, > > >> while this is patch is correct, I do not really care about staging drivers that actually bluntly violate my copyright. > >> > > > > That's very cryptic. > > > > What is going on here? I googled it and I wasn't able to find what you > > are talking about. Care to give us a hint and what you want us to do > > here? > > the last time I checked, the majority of drivers/bluetooth/btusb.c has been written by myself. Now go and compare btusb.c to btmtk_usb.[ch]. > > > I have also added Johan Hedberg to the CC list because he also helped > > break the build. Don't do that. > > Yes, we are doing exactly that. It is a staging driver. I could not care less if a staging drivers breaks the build or not. > > If anybody cares about this driver, then take the time to merge it upstream. It has never been submitted to linux-bluetooth mailing list. > > There are drivers that should have never been merged into staging. > This is one of them. Look for yourself and explain to me why this > driver is part of staging in the first place. Because it was sent to me by a developer? Seriously, what's the issue here, I didn't notice it was a fork of your code, sorry, I didn't check. I figured it would be eventually cleaned up properly and then it will be sent to linux-bluetooth for proper merging. Yu-Chen, what's the satus of getting this cleaned up "properly"? You haven't really done anything on this since I took the driver in May. thanks, greg k-h