Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 06/13] android/handsfree: Add SDP record for AG
Date: Mon, 3 Feb 2014 09:56:18 +0200	[thread overview]
Message-ID: <20140203075616.GB2930@aemeltch-MOBL1> (raw)
In-Reply-To: <1391375364-27106-7-git-send-email-szymon.janc@tieto.com>

Hi Szymon,

On Sun, Feb 02, 2014 at 10:09:17PM +0100, Szymon Janc wrote:
> Service Name: Hands-Free Audio GatewayService RecHandle: 0x10001
> Service Class ID List:
>   "Handsfree Audio Gateway" (0x111f)
>   "Generic Audio" (0x1203)
> Protocol Descriptor List:
>   "L2CAP" (0x0100)
>   "RFCOMM" (0x0003)
>     Channel: 13
> Profile Descriptor List:
>   "Handsfree" (0x111e)
>     Version: 0x0106
> ---
>  android/handsfree.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 97 insertions(+)
> 
> diff --git a/android/handsfree.c b/android/handsfree.c
> index 3c0d52b..d2dc543 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -29,12 +29,19 @@
>  #include <glib.h>
>  
>  #include "lib/bluetooth.h"
> +#include "lib/sdp.h"
> +#include "lib/sdp_lib.h"
>  #include "handsfree.h"
> +#include "bluetooth.h"
>  #include "src/log.h"
>  #include "hal-msg.h"
>  #include "ipc.h"
>  
> +#define HFP_AG_CHANNEL 13
> +#define HFP_AG_FEATURES 0
> +
>  static bdaddr_t adapter_addr;
> +static uint32_t record_id = 0;
>  
>  static void handle_connect(const void *buf, uint16_t len)
>  {
> @@ -189,12 +196,99 @@ static const struct ipc_handler cmd_handlers[] = {
>  			sizeof(struct hal_cmd_handsfree_phone_state_change)},
>  };
>  
> +static sdp_record_t *handsfree_ag_record(void)
> +{
> +	sdp_list_t *svclass_id, *pfseq, *apseq, *root;
> +	uuid_t root_uuid, svclass_uuid, ga_svclass_uuid;
> +	uuid_t l2cap_uuid, rfcomm_uuid;
> +	sdp_profile_desc_t profile;
> +	sdp_list_t *aproto, *proto[2];
> +	sdp_record_t *record;
> +	sdp_data_t *channel, *features;
> +	uint8_t netid = 0x01;
> +	uint16_t sdpfeat;
> +	sdp_data_t *network;
> +	uint8_t ch = HFP_AG_CHANNEL;
> +
> +	record = sdp_record_alloc();
> +	if (!record)
> +		return NULL;
> +
> +	network = sdp_data_alloc(SDP_UINT8, &netid);
> +	if (!network) {
> +		sdp_record_free(record);
> +		return NULL;
> +	}
> +
> +	sdp_uuid16_create(&root_uuid, PUBLIC_BROWSE_GROUP);
> +	root = sdp_list_append(0, &root_uuid);
> +	sdp_set_browse_groups(record, root);
> +
> +	sdp_uuid16_create(&svclass_uuid, HANDSFREE_AGW_SVCLASS_ID);
> +	svclass_id = sdp_list_append(0, &svclass_uuid);
> +	sdp_uuid16_create(&ga_svclass_uuid, GENERIC_AUDIO_SVCLASS_ID);
> +	svclass_id = sdp_list_append(svclass_id, &ga_svclass_uuid);
> +	sdp_set_service_classes(record, svclass_id);
> +
> +	sdp_uuid16_create(&profile.uuid, HANDSFREE_PROFILE_ID);
> +	profile.version = 0x0106;
> +	pfseq = sdp_list_append(0, &profile);
> +	sdp_set_profile_descs(record, pfseq);
> +
> +	sdp_uuid16_create(&l2cap_uuid, L2CAP_UUID);
> +	proto[0] = sdp_list_append(0, &l2cap_uuid);
> +	apseq = sdp_list_append(0, proto[0]);
> +
> +	sdp_uuid16_create(&rfcomm_uuid, RFCOMM_UUID);
> +	proto[1] = sdp_list_append(0, &rfcomm_uuid);
> +	channel = sdp_data_alloc(SDP_UINT8, &ch);
> +	proto[1] = sdp_list_append(proto[1], channel);
> +	apseq = sdp_list_append(apseq, proto[1]);
> +
> +	sdpfeat = HFP_AG_FEATURES;
> +	features = sdp_data_alloc(SDP_UINT16, &sdpfeat);
> +	sdp_attr_add(record, SDP_ATTR_SUPPORTED_FEATURES, features);
> +
> +	aproto = sdp_list_append(0, apseq);
> +	sdp_set_access_protos(record, aproto);
> +
> +	sdp_set_info_attr(record, "Hands-Free Audio Gateway", 0, 0);
> +
> +	sdp_attr_add(record, SDP_ATTR_EXTERNAL_NETWORK, network);
> +
> +	sdp_data_free(channel);
> +	sdp_list_free(proto[0], 0);

We have agreed to use NULL for zero pointers.

Best regards 
Andrei Emeltchenko 


  reply	other threads:[~2014-02-03  7:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-02 21:09 [PATCH 00/13] Initial code for handsfree support Szymon Janc
2014-02-02 21:09 ` [PATCH 01/13] android/handsfree: Add initial files Szymon Janc
2014-02-02 21:09 ` [PATCH 02/13] android/handsfree: Add commands and events definition to IPC header Szymon Janc
2014-02-02 21:09 ` [PATCH 03/13] android/handsfree: Add stubs for commands handlers Szymon Janc
2014-02-02 21:09 ` [PATCH 04/13] android/hal-handsfree: Implement notifications handling Szymon Janc
2014-02-02 21:09 ` [PATCH 05/13] android/hal-handsfree: Implement sending commands Szymon Janc
2014-02-02 21:09 ` [PATCH 06/13] android/handsfree: Add SDP record for AG Szymon Janc
2014-02-03  7:56   ` Andrei Emeltchenko [this message]
2014-02-05  9:10     ` Szymon Janc
2014-02-02 21:09 ` [PATCH 07/13] android/handsfree: Add support for RFCOMM connection handling Szymon Janc
2014-02-02 21:09 ` [PATCH 08/13] android/handsfree: Add initial code for AT commands processing Szymon Janc
2014-02-02 21:09 ` [PATCH 09/13] android/handsfree: Add connect command handling Szymon Janc
2014-02-02 21:09 ` [PATCH 10/13] android/handsfree: Add disconnect " Szymon Janc
2014-02-02 21:09 ` [PATCH 11/13] android/handsfree: Add AT+BRSF command support Szymon Janc
2014-02-02 21:09 ` [PATCH 12/13] android/handsfree: Add support for AT+CIND command Szymon Janc
2014-02-02 21:09 ` [PATCH 13/13] android/handsfree: Add support for AT+CMER command Szymon Janc
2014-02-05  9:10 ` [PATCH 00/13] Initial code for handsfree support Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140203075616.GB2930@aemeltch-MOBL1 \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox