From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] unit/avctp: Use pre-defined values instead of magic numbers
Date: Tue, 11 Feb 2014 13:12:04 +0200 [thread overview]
Message-ID: <20140211111202.GC8980@aemeltch-MOBL1> (raw)
In-Reply-To: <1391614102-21639-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
ping
On Wed, Feb 05, 2014 at 05:28:21PM +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> unit/test-avctp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/unit/test-avctp.c b/unit/test-avctp.c
> index 581f88c..9d94ae0 100644
> --- a/unit/test-avctp.c
> +++ b/unit/test-avctp.c
> @@ -277,8 +277,8 @@ static void test_client(gconstpointer data)
> {
> struct context *context = create_context(0x0100, data);
>
> - avctp_send_vendordep_req(context->session, 0, 0, NULL, 0,
> - handler_response, context);
> + avctp_send_vendordep_req(context->session, AVC_CTYPE_CONTROL, 0, NULL,
> + 0, handler_response, context);
>
> execute_context(context);
> }
> @@ -290,8 +290,8 @@ static void test_server(gconstpointer data)
> if (g_str_equal(context->data->test_name, "/TP/NFR/BV-03-C")) {
> int ret;
>
> - ret = avctp_register_pdu_handler(context->session, 0x00,
> - handler, NULL);
> + ret = avctp_register_pdu_handler(context->session,
> + AVC_OP_VENDORDEP, handler, NULL);
> DBG("ret %d", ret);
> g_assert_cmpint(ret, !=, 0);
> }
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-11 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 15:28 [PATCH 1/2] unit/avctp: Use pre-defined values instead of magic numbers Andrei Emeltchenko
2014-02-05 15:28 ` [PATCH 2/2] unit/avctp: Cleanup code, remove fragmentation support Andrei Emeltchenko
2014-02-11 11:12 ` Andrei Emeltchenko [this message]
2014-02-11 18:34 ` [PATCH 1/2] unit/avctp: Use pre-defined values instead of magic numbers Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211111202.GC8980@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox