From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "bluez mailin list (linux-bluetooth@vger.kernel.org)"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Fix advertising address type when toggling connectable
Date: Tue, 25 Feb 2014 19:32:42 +0200 [thread overview]
Message-ID: <20140225173242.GA4779@localhost.P-661HNU-F1> (raw)
In-Reply-To: <84898D84-C149-4ABE-8CFE-55FB2E261CF6@holtmann.org>
Hi Marcel,
On Tue, Feb 25, 2014, Marcel Holtmann wrote:
> > - bool require_privacy;
> > + bool connectable, require_privacy;
> >
> > - require_privacy = !test_bit(HCI_CONNECTABLE, &hdev->dev_flags);
> > + connectable = get_connectable(hdev);
> > + require_privacy = !connectable;
> >
> > if (hci_update_random_address(req, require_privacy, &own_addr_type) < 0)
> > return;
>
> can we use a comment here to explain require_privacy like we do with
> the other time it is used. the two variables are too much. And then
> call it like this ..address(req, !connectable, &own..).
Sure. v2 coming in a few minutes.
Johan
prev parent reply other threads:[~2014-02-25 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 13:10 [PATCH] Bluetooth: Fix advertising address type when toggling connectable johan.hedberg
2014-02-25 13:10 ` johan.hedberg
2014-02-25 17:26 ` Marcel Holtmann
2014-02-25 17:32 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225173242.GA4779@localhost.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox