Re: [PATCH v2] Bluetooth: Fix advertising address type when toggling connectable

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Marcel,

On Tue, Feb 25, 2014, Marcel Holtmann wrote:
> > -	if (hci_update_random_address(req, require_privacy, &own_addr_type) < 0)
> > +	/* If we're connectable set require_privacy to false as we
> > +	 * shouldn't use NRPAs in that case. If we're non-connectable
> > +	 * however we can allow NRPAs to be used.
> > +	 */
> > +	if (hci_update_random_address(req, !connectable, &own_addr_type) < 0)
> > 		return;
> 
> I really do not want to be pedantic, but this comment is misleading.
> It is a bit hard to understand. Also I am not sure if it NRPA or URPA.

It's "non-resolvable" according to the core specification.

> I think using an acronym here is confusing.
> 
> 	/* Set require_privacy to true only when non-connectable advertising
> 	 * is used. In that case it is fine to use an unresolvable private
> 	 * address.
> 	 */ 

v3 has been sent.

Johan