From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Bluetooth: Use __le64 type for LE random numbers
Date: Fri, 28 Feb 2014 09:45:08 +0200 [thread overview]
Message-ID: <20140228074508.GA724@localhost.P-661HNU-F1> (raw)
In-Reply-To: <1393545628-29566-1-git-send-email-marcel@holtmann.org>
Hi Marcel,
On Thu, Feb 27, 2014, Marcel Holtmann wrote:
> The random numbers in Bluetooth Low Energy are 64-bit numbers and should
> also be little endian since the HCI specification is little endian.
>
> Change the whole Low Energy pairing to use __le64 instead of a byte
> array.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> include/net/bluetooth/hci.h | 4 ++--
> include/net/bluetooth/hci_core.h | 8 ++++----
> include/net/bluetooth/mgmt.h | 2 +-
> net/bluetooth/hci_conn.c | 6 +++---
> net/bluetooth/hci_core.c | 13 ++++++-------
> net/bluetooth/hci_event.c | 2 +-
> net/bluetooth/mgmt.c | 2 +-
> net/bluetooth/smp.c | 22 ++++++++++------------
> net/bluetooth/smp.h | 2 +-
> 9 files changed, 29 insertions(+), 32 deletions(-)
Applied to bluetooth-next. Thanks.
Johan
prev parent reply other threads:[~2014-02-28 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 0:00 [RFC] Bluetooth: Use __le64 type for LE random numbers Marcel Holtmann
2014-02-28 7:45 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228074508.GA724@localhost.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox