Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 0/3] Fix GATT server issues with BlueZ as LE peripheral
Date: Wed, 5 Mar 2014 22:40:19 +0200	[thread overview]
Message-ID: <20140305204019.GA14755@localhost.P-661HNU-F1> (raw)
In-Reply-To: <1390924298-13804-1-git-send-email-anderson.lizardo@openbossa.org>

Hi Lizardo,

On Tue, Jan 28, 2014, Anderson Lizardo wrote:
> Currently, we do not officially support running BlueZ as LE peripheral. But
> there is already enough support from the kernel to support this. For instance,
> there is the "Set Advertising" mgmt command to keep LE advertising enabled
> after each connection.
> 
> The current tracking of connections in BlueZ does not fully work for peripheral
> role. These patches are a first attempt to improve the situation. Other fixes
> are necessary to have full LE Peripheral support.
> 
> In particular, with these patches, notifications for PASP and ANP profiles
> (implemented in profiles/alert/*) should work when BlueZ is on the peripheral
> role. Other GATT server profiles will need fixing as well.
> 
> I'm sending as RFC because I only did minimal testing. I hope that people
> having issues with GATT server profiles running on peripheral role can tests
> these patches. Otherwise, I'll do more tests later today and send a final
> version by tomorrow.
> 
> Notes: 
> * The first patch is just cleanup, so can be applied as is.
> * For testing, make sure to enable advertising on the machine running as
>   peripheral (I use btmgmt tool for this).
> 
> Best Regards,
> Anderson Lizardo
> 
> Anderson Lizardo (3):
>   attrib-server: Remove unnecessary fields from struct gatt_channel
>   core: Fix associating a GAttrib to a device on incoming connections
>   alert: Only remove attio callback after ATT request was sent
> 
>  profiles/alert/server.c | 18 +++++++++++++++++-
>  src/attrib-server.c     | 45 +++++++++++++++++++++++++++++----------------
>  src/attrib-server.h     |  1 +
>  src/device.c            |  5 +++++
>  4 files changed, 52 insertions(+), 17 deletions(-)

These patches seem to have been forgotten about. They looked fairly good
to me so I rebased and applied them finally.

Johan

  parent reply	other threads:[~2014-03-05 20:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 15:51 [RFC BlueZ 0/3] Fix GATT server issues with BlueZ as LE peripheral Anderson Lizardo
2014-01-28 15:51 ` [RFC BlueZ 1/3] attrib-server: Remove unnecessary fields from struct gatt_channel Anderson Lizardo
2014-01-28 15:51 ` [RFC BlueZ 2/3] core: Fix associating a GAttrib to a device on incoming connections Anderson Lizardo
2014-01-28 15:51 ` [RFC BlueZ 3/3] alert: Only remove attio callback after ATT request was sent Anderson Lizardo
2014-03-05 20:40 ` Johan Hedberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-01-29  6:51 [RFC BlueZ 0/3] Fix GATT server issues with BlueZ as LE peripheral Isa Ansharullah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305204019.GA14755@localhost.P-661HNU-F1 \
    --to=johan.hedberg@gmail.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox