Re: [PATCH BlueZ 1/4] android/avrcp-lib: Add avrcp_register_notification function

[Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>]

Hi Luiz,

On Fri, Mar 07, 2014 at 03:00:30PM +0200, Luiz Augusto von Dentz wrote:
> Hi Andrei,
> 
> On Fri, Mar 7, 2014 at 2:22 PM, Andrei Emeltchenko
> <andrei.emeltchenko.news@gmail.com> wrote:
> > Hi Luiz,
> >
> > On Fri, Mar 07, 2014 at 02:15:40PM +0200, Luiz Augusto von Dentz wrote:
> >> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >>
> >> This adds avrcp_register_notification which can be used to send
> >> RegisterNotification PDUs.
> >
> > Didn't I sent the same patch already? Why are we redoing the same work?
> 
> Im implementing the daemon side, this is the problem of sending big
> patch sets it takes more time and I want to finish the AVRCP quickly
> so we can have it tested. Btw, Im not sure why you are still defining
> the PDU length public, 

The pdu lengths might be used in unit tests and avrcp-lib.

Best regards 
Andrei Emeltchenko 

> this should probably be keep private until we
> have proper struct defined, in fact I did mention that we might change
> the way the handlers works in avrcp-lib to incorporate more logic and
> do things like header checks that the unit test has been doing.