From: Johan Hedberg <johan.hedberg@gmail.com>
To: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 01/10] emulator: Minor style fix
Date: Wed, 12 Mar 2014 13:22:15 +0200 [thread overview]
Message-ID: <20140312112215.GA7489@localhost.P-661HNU-F1> (raw)
In-Reply-To: <1394406363-6751-2-git-send-email-lukasz.rymanowski@tieto.com>
Hi Lukasz,
On Mon, Mar 10, 2014, Lukasz Rymanowski wrote:
> ---
> emulator/btdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index b54f91e..2cf8f89 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -709,8 +709,8 @@ static void inquiry_complete(struct btdev *btdev, uint8_t status)
> ir.rssi = -60;
> memcpy(ir.data, btdev_list[i]->ext_inquiry_rsp, 240);
>
> - send_event(btdev, BT_HCI_EVT_EXT_INQUIRY_RESULT,
> - &ir, sizeof(ir));
> + send_event(btdev, BT_HCI_EVT_EXT_INQUIRY_RESULT, &ir,
> + sizeof(ir));
> continue;
> }
>
> @@ -738,8 +738,8 @@ static void inquiry_complete(struct btdev *btdev, uint8_t status)
> memcpy(ir.dev_class, btdev_list[i]->dev_class, 3);
> ir.clock_offset = 0x0000;
>
> - send_event(btdev, BT_HCI_EVT_INQUIRY_RESULT,
> - &ir, sizeof(ir));
> + send_event(btdev, BT_HCI_EVT_INQUIRY_RESULT, &ir,
> + sizeof(ir));
> }
> }
I wouldn't bother with this one. The reason these two variables have
been put on the same line is that they are tightly related to each
other.
Johan
next prev parent reply other threads:[~2014-03-12 11:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 23:05 [PATCH v2 00/10] Change inquiry handling in btdev Lukasz Rymanowski
2014-03-09 23:05 ` [PATCH v2 01/10] emulator: Minor style fix Lukasz Rymanowski
2014-03-12 11:22 ` Johan Hedberg [this message]
2014-03-09 23:05 ` [PATCH v2 02/10] emulator: Use timeout for sending inquiry results Lukasz Rymanowski
2014-03-12 11:28 ` Johan Hedberg
2014-03-14 15:56 ` Lukasz Rymanowski
2014-03-09 23:05 ` [PATCH v2 03/10] emulator: Add inquiry cancel Lukasz Rymanowski
2014-03-12 11:39 ` Johan Hedberg
2014-03-14 15:57 ` Lukasz Rymanowski
2014-03-09 23:05 ` [PATCH v2 04/10] emulator: Add handling inquiry number of responses Lukasz Rymanowski
2014-03-12 11:42 ` Johan Hedberg
2014-03-14 15:57 ` Lukasz Rymanowski
2014-03-09 23:05 ` [PATCH v2 05/10] emulator: Add handling inquiry_lenght from inquiry command Lukasz Rymanowski
2014-03-12 11:44 ` Johan Hedberg
2014-03-14 15:57 ` Lukasz Rymanowski
2014-03-09 23:05 ` [PATCH v2 06/10] android/tester: Fix handling inquiry by android tester Lukasz Rymanowski
2014-03-09 23:06 ` [PATCH v2 07/10] tools/mgmt-tester: Fix for Stop discovery test Lukasz Rymanowski
2014-03-09 23:06 ` [PATCH v2 08/10] tools/mgmt-tester: Update Stop Discovery-BR/EDR (Inquiry) Success 1 Lukasz Rymanowski
2014-03-09 23:06 ` [PATCH v2 09/10] tools/mgmt-tester: Remove not used condition Lukasz Rymanowski
2014-03-09 23:06 ` [PATCH v2 10/10] tools/mgmt-tester: Refactor setup_start_discovery function Lukasz Rymanowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312112215.GA7489@localhost.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lukasz.rymanowski@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox