From: Johan Hedberg <johan.hedberg@gmail.com>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/3] Various build fixes for building bluez with musl libc
Date: Fri, 14 Mar 2014 13:07:19 +0200 [thread overview]
Message-ID: <20140314110719.GA11158@localhost.P-661HNU-F1> (raw)
In-Reply-To: <1394791167-29933-1-git-send-email-ncopa@alpinelinux.org>
Hi Natanael,
On Fri, Mar 14, 2014, Natanael Copa wrote:
> The following fixes are needed to make bluez build on Alpine Linuz with
> musl libc.
>
> This is kind of a rebase of the previously posted patches:
> http://www.spinics.net/lists/linux-bluetooth/msg43070.html
>
> Changes since then are:
> - mention Alpine Linux in commit message
> - rebase to current git
> - added fix for proper header include for be32toh, htobe32 and htobe64
>
> Please note that "unit: prevent unintended use of glibc's error(3)"
> fixes a bug in the unit test that affects glibc too. I suppose that if
> you add a testcase that triggers any error logging from sdpd-request.c
> it will likely segfault instead of gracfully hande the error condition.
> (it only affects the unit test though)
>
> Natanael Copa (3):
> shared: include endian.h for be32toh, htobe32 and htobe64 functions
> unit: prevent unintended use of glibc's error(3)
> bnep: avoid use of caddr_t
>
> Makefile.am | 1 +
> profiles/network/bnep.c | 4 ++--
> src/shared/btsnoop.c | 1 +
> unit/test-sdp.c | 9 +++------
> 4 files changed, 7 insertions(+), 8 deletions(-)
I've applied patches 1 and 3, but am waiting for a v2 on patch 2 since
it breaks the build:
unit/test-sdp.c: In function ‘main’:
unit/test-sdp.c:795:3: error: implicit declaration of function ‘__btd_log_init’ [-Werror=implicit-function-declaration]
__btd_log_init("*", 0);
Johan
next prev parent reply other threads:[~2014-03-14 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 9:59 [PATCH 0/3] Various build fixes for building bluez with musl libc Natanael Copa
2014-03-14 9:59 ` [PATCH 1/3] shared: include endian.h for be32toh, htobe32 and htobe64 functions Natanael Copa
2014-03-14 9:59 ` [PATCH 2/3] unit: prevent unintended use of glibc's error(3) Natanael Copa
2014-03-14 9:59 ` [PATCH 3/3] bnep: avoid use of caddr_t Natanael Copa
2014-03-14 11:07 ` Johan Hedberg [this message]
2014-03-14 11:30 ` [PATCH 0/3] Various build fixes for building bluez with musl libc Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314110719.GA11158@localhost.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ncopa@alpinelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox