From: Johan Hedberg <johan.hedberg@gmail.com>
To: Petri Gynther <pgynther@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] hog: Fix report_value_cb()
Date: Fri, 9 May 2014 14:50:45 +0300 [thread overview]
Message-ID: <20140509115045.GA3536@t440s.lan> (raw)
In-Reply-To: <20140509014001.0A027100DB2@puck.mtv.corp.google.com>
Hi Petri,
On Thu, May 08, 2014, Petri Gynther wrote:
> 1. Fix potential buffer overflow. It would happen in the case:
> hogdev->has_report_id == TRUE && report_size == UHID_DATA_MAX
>
> 2. Adjust function signature to match GAttribNotifyFunc.
>
> 3. Adjust uHID error handling to mimic uhid_send_input_report() in
> profiles/input/device.c
> ---
> profiles/input/hog.c | 44 +++++++++++++++++++++++++++++---------------
> 1 file changed, 29 insertions(+), 15 deletions(-)
Whenever I see a commit message like this it begs the question:
shouldn't these separate fixes be in separate patches? If at all
possible please split the patch into smaller ones so that each one
contains a single independent fix. That makes it much easier to track
exactly which code change maps to which described fix as well the
possibility to do some bisecting later in case one of the fixes
introduces a bug.
Johan
next prev parent reply other threads:[~2014-05-09 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 1:40 [PATCH] hog: Fix report_value_cb() Petri Gynther
2014-05-09 11:50 ` Johan Hedberg [this message]
2014-05-09 16:44 ` Petri Gynther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509115045.GA3536@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox