From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv6 07/11] android/audio: Add resampler support
Date: Tue, 13 May 2014 13:55:19 +0300 [thread overview]
Message-ID: <20140513105441.GA27218@aemeltch-MOBL1> (raw)
In-Reply-To: <48B10FF8-C2D8-4528-AF0D-497D96546A5B@holtmann.org>
Hi Marcel,
On Mon, May 12, 2014 at 06:29:40PM -0700, Marcel Holtmann wrote:
> Hi Andrei,
>
> > The patch adds support for resampling audio in host and Android. There
> > are Android wrappers for SPEEXDSP library added to host.
> > ---
> > android/Android.mk | 2 +
> > android/Makefile.am | 6 +-
> > android/audio_utils/resampler.c | 265 ++++++++++++++++++++++++++++++++++++++++
> > android/audio_utils/resampler.h | 109 +++++++++++++++++
> > configure.ac | 7 ++
> > 5 files changed, 388 insertions(+), 1 deletion(-)
> > create mode 100644 android/audio_utils/resampler.c
> > create mode 100644 android/audio_utils/resampler.h
> >
> > diff --git a/android/Android.mk b/android/Android.mk
> > index 6d0169b..cc0f8f5 100644
> > --- a/android/Android.mk
> > +++ b/android/Android.mk
> > @@ -282,9 +282,11 @@ LOCAL_SRC_FILES := bluez/android/hal-sco.c
> > LOCAL_C_INCLUDES = \
> > $(call include-path-for, system-core) \
> > $(call include-path-for, libhardware) \
> > + $(call include-path-for, audio-utils) \
> >
> > LOCAL_SHARED_LIBRARIES := \
> > libcutils \
> > + libaudioutils \
> >
>
> where is this coming from? Why this directory? Why this name?
This is standard Android library and directory name. You can search it in
Android AOSP.
> Why not use compile it directly into the SCO audio module and use a name like android/audio_resampler.[ch].
This is standard Android library used also by other projects.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2014-05-13 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 8:56 [PATCHv6 01/11] android/hal-audio-hsp: Add open_output_stream() Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 02/11] android/audio: Add Audio SCO message API Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 03/11] android/handsfree: Add SCO Audio IPC Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 04/11] android/hal-sco: Implement Audio IPC on Audio HAL Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 05/11] android/ipc: Use error printing error messages Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 06/11] android/haltest: Add testinng for audio SCO HAL Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 07/11] android/audio: Add resampler support Andrei Emeltchenko
2014-05-13 1:29 ` Marcel Holtmann
2014-05-13 10:55 ` Andrei Emeltchenko [this message]
2014-05-12 8:57 ` [PATCHv6 08/11] audio/haltest: Make audio_stream static Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 09/11] android/audio: Add downmix support to audio SCO HAL Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 10/11] android/audio: Use resampler interface to resample SCO Andrei Emeltchenko
2014-05-12 8:57 ` [PATCHv6 11/11] android/audio: Add write to SCO Andrei Emeltchenko
2014-05-13 11:22 ` [PATCHv6 01/11] android/hal-audio-hsp: Add open_output_stream() Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513105441.GA27218@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).