Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vikrampal <vikram.pal@samsung.com>
Cc: linux-bluetooth@vger.kernel.org,
	Dmitry Kasatkin <d.kasatkin@samsung.com>,
	bharat.panda@samsung.com, p.sinha@samsung.com, cpgs@samsung.com
Subject: Re: Add SDP discovery support to gatttool with BR
Date: Wed, 14 May 2014 10:56:17 +0300	[thread overview]
Message-ID: <20140514075617.GA28535@t440s.lan> (raw)
In-Reply-To: <004201cf6a99$bbc7d590$335780b0$@samsung.com>

Hi Vikram,

On Thu, May 08, 2014, Vikrampal wrote:
> I am new to BlueZ community. I'd like to contribute to BlueZ community. I
> went through BlueZ's TODO items. 
> To get started, I have selected adding SDP discovery support to gatttool
> with BR as my first work.
> 
> - Add sdp discovery support to gatttool with BR (--sdp, default is 0x1f)

Not sure what exactly you mean here. ATT over BR/EDR uses a fixed PSM so
separate discovery of this is not necessary. The core spec says:

"The use of a fixed PSM allows rapid reconnection of the L2CAP channel
for Attribute Protocol as a preliminary SDP query is not required."

Based on git blame this item was added 5th Oct 2010, i.e. in the very
early days of the LE specification. I suspect that there might have been
some confusion regarding the ATT PSM back then. While this kind of PSM
discovery it's not completely pointless, we don't do it for any other
fixed PSM profiles either (e.g. A2DP & AVRCP) so I think it's better to
spend time on more valuable tasks instead.

I've now removed the ATT PSM related items from the TODO file (which btw
could use much more cleanups in general).

Johan

  parent reply	other threads:[~2014-05-14  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  8:44 Add SDP discovery support to gatttool with BR Vikrampal
2014-05-14  6:13 ` Dmitry Kasatkin
2014-05-14  7:56 ` Johan Hedberg [this message]
2014-05-15 10:49   ` Vikrampal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140514075617.GA28535@t440s.lan \
    --to=johan.hedberg@gmail.com \
    --cc=bharat.panda@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=d.kasatkin@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=p.sinha@samsung.com \
    --cc=vikram.pal@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox