From: Johan Hedberg <johan.hedberg@gmail.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] shared/tester: Add support for debug logs for tester
Date: Wed, 21 May 2014 14:05:40 +0300 [thread overview]
Message-ID: <20140521110540.GA22193@t440s.lan> (raw)
In-Reply-To: <1399473907-9698-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Wed, May 07, 2014, Grzegorz Kolodziejczyk wrote:
> +void tester_debug(const char *format, ...)
> +{
> + va_list ap;
> +
> + if (!tester_use_debug())
> + return;
> +
> + printf(" tester-dbg: %s", COLOR_WHITE);
I think it'd be good to make the prefix consistent with the other
logging functions here. Do we really need to know that a line is a debug
print? Isn't it simply enough that the line is printed when debugging is
enabled? I don't see any special identifiers for the other types of logs
either. So unless there's a good reason to have it I'd just keep this
consistent with the other logs.
Johan
next prev parent reply other threads:[~2014-05-21 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 14:45 [PATCH] shared/tester: Add support for debug logs for tester Grzegorz Kolodziejczyk
2014-05-21 7:46 ` Grzegorz Kolodziejczyk
2014-05-21 11:05 ` Johan Hedberg [this message]
2014-05-21 11:55 ` Grzegorz Kolodziejczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521110540.GA22193@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox