From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] gatt: Fix not freeing GError on failure
Date: Wed, 21 May 2014 17:54:31 +0300 [thread overview]
Message-ID: <20140521145431.GA30054@t440s> (raw)
In-Reply-To: <1400682882-11341-3-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Wed, May 21, 2014, Jakub Tyszkowski wrote:
> + if (gerr) {
> + error("Could not acquire att imtu and cid: %s", gerr->message);
> + free(gerr);
> + }
Good catch, but GErrors are freed with g_error_free()
Johan
next prev parent reply other threads:[~2014-05-21 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 14:34 [PATCH 1/3] android/gatt: Check for connection state on connection search Jakub Tyszkowski
2014-05-21 14:34 ` [PATCH 2/3] attrib: Fix minor whitespace issue Jakub Tyszkowski
2014-05-21 14:34 ` [PATCH 3/3] gatt: Fix not freeing GError on failure Jakub Tyszkowski
2014-05-21 14:54 ` Johan Hedberg [this message]
2014-05-22 11:01 ` [PATCHv2] " Jakub Tyszkowski
2014-05-22 12:12 ` [PATCH 1/3] android/gatt: Check for connection state on connection search Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521145431.GA30054@t440s \
--to=johan.hedberg@gmail.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox