Re: [PATCH] android/gatt: Fix wrong initial value

[Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>]

On Thu, Jun 12, 2014 at 01:05:45PM +0200, Marcin Kraglak wrote:
> Hi Andrei,
> 
> On 12 June 2014 12:43, Andrei Emeltchenko
> <Andrei.Emeltchenko.news@gmail.com> wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> >
> > Initialize value_len to -1 since otherwise check value_len >= 0 does not
> > make sense.
> > ---
> >  android/gatt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/android/gatt.c b/android/gatt.c
> > index 8da77d0..8260a8d 100644
> > --- a/android/gatt.c
> > +++ b/android/gatt.c
> > @@ -4147,7 +4147,7 @@ static void read_requested_attributes(void *data, void *user_data)
> >         struct request_processing_data *process_data = user_data;
> >         uint32_t permissions;
> >         uint8_t *value, error;
> > -       int value_len = 0;
> > +       int value_len = -1;
> 
> What will happen if check_device_permissions will fail?

nothing? Should we send message?

Best regards 
Andrei Emeltchenko