From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/hal-health: Clear NONBLOCK flag from fd
Date: Thu, 3 Jul 2014 17:08:09 +0300 [thread overview]
Message-ID: <20140703140807.GG7283@aemeltch-MOBL1> (raw)
In-Reply-To: <700D9D34-C873-4A39-858C-68265704A8EB@holtmann.org>
Hi Marcel,
On Thu, Jul 03, 2014 at 12:38:29PM +0200, Marcel Holtmann wrote:
> > +
> > + fcntl(fd, F_SETFL, flags & ~O_NONBLOCK);
> > +
>
> Same here. Might check the return error and print an error if it fails.
> At least then someone can debug it.
I have some other patch hanging in my tree checking return from ioctl()
for avctp. I will send it in a moment.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2014-07-03 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 10:31 [PATCH] android/hal-health: Clear NONBLOCK flag from fd Andrei Emeltchenko
2014-07-03 10:38 ` Marcel Holtmann
2014-07-03 10:46 ` Andrei Emeltchenko
2014-07-03 14:08 ` Andrei Emeltchenko [this message]
2014-07-03 14:12 ` [PATCH] avctp: Fix unchecked return value Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703140807.GG7283@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox