* [PATCH 1/2] android/hal-sco: Remove unneeded check
@ 2014-07-18 14:35 Andrei Emeltchenko
2014-07-18 14:35 ` [PATCH 2/2] android/hal-audio: " Andrei Emeltchenko
2014-07-21 8:42 ` [PATCH 1/2] android/hal-sco: " Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-07-18 14:35 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
rsp_len cannot be NULL since it checked for NULL in the beginning of the
function.
---
android/hal-sco.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/android/hal-sco.c b/android/hal-sco.c
index b13eb91..62e16a8 100644
--- a/android/hal-sco.c
+++ b/android/hal-sco.c
@@ -265,8 +265,7 @@ static int sco_ipc_cmd(uint8_t service_id, uint8_t opcode, uint16_t len,
goto failed;
}
- if (rsp_len)
- *rsp_len = cmd.len;
+ *rsp_len = cmd.len;
return SCO_STATUS_SUCCESS;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] android/hal-audio: Remove unneeded check
2014-07-18 14:35 [PATCH 1/2] android/hal-sco: Remove unneeded check Andrei Emeltchenko
@ 2014-07-18 14:35 ` Andrei Emeltchenko
2014-07-21 8:42 ` [PATCH 1/2] android/hal-sco: " Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-07-18 14:35 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
rsp_len cannot be NULL here because of NULL check in the beginning of
the function.
---
android/hal-audio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/android/hal-audio.c b/android/hal-audio.c
index d7a06fa..66dc46a 100644
--- a/android/hal-audio.c
+++ b/android/hal-audio.c
@@ -286,8 +286,7 @@ static int audio_ipc_cmd(uint8_t service_id, uint8_t opcode, uint16_t len,
goto failed;
}
- if (rsp_len)
- *rsp_len = cmd.len;
+ *rsp_len = cmd.len;
return AUDIO_STATUS_SUCCESS;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] android/hal-sco: Remove unneeded check
2014-07-18 14:35 [PATCH 1/2] android/hal-sco: Remove unneeded check Andrei Emeltchenko
2014-07-18 14:35 ` [PATCH 2/2] android/hal-audio: " Andrei Emeltchenko
@ 2014-07-21 8:42 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2014-07-21 8:42 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Fri, Jul 18, 2014, Andrei Emeltchenko wrote:
> rsp_len cannot be NULL since it checked for NULL in the beginning of the
> function.
> ---
> android/hal-sco.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Both patches have been applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-21 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-18 14:35 [PATCH 1/2] android/hal-sco: Remove unneeded check Andrei Emeltchenko
2014-07-18 14:35 ` [PATCH 2/2] android/hal-audio: " Andrei Emeltchenko
2014-07-21 8:42 ` [PATCH 1/2] android/hal-sco: " Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).