From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/ipc: Rename connect_sco to get_fd
Date: Mon, 21 Jul 2014 11:57:30 +0300 [thread overview]
Message-ID: <20140721085730.GB27596@t440s.lan> (raw)
In-Reply-To: <1405689994-27037-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Fri, Jul 18, 2014, Andrei Emeltchenko wrote:
> SCO get connected through handsfree HAL and Audio SCO HAL only need to
> get SCO socket fd.
> ---
> android/hal-sco.c | 4 ++--
> android/handsfree.c | 10 +++++-----
> android/sco-ipc-api.txt | 6 +++---
> android/sco-msg.h | 4 ++--
> 4 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/android/hal-sco.c b/android/hal-sco.c
> index 0e87aad..e07bb9a 100644
> --- a/android/hal-sco.c
> +++ b/android/hal-sco.c
> @@ -285,12 +285,12 @@ static int ipc_connect_sco(void)
Shouldn't you change the name of this ipc_connect_sco function too?
> pthread_mutex_lock(&sco_mutex);
>
> if (sco_fd < 0) {
> - struct sco_rsp_connect rsp;
> + struct sco_rsp_get_fd rsp;
> size_t rsp_len = sizeof(rsp);
>
> DBG("Connecting SCO");
And this debug log?
Johan
next prev parent reply other threads:[~2014-07-21 8:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:47 [PATCHv2 00/21] Second iteration of SCO Audio HAL fixes Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 01/21] android/hal-sco: Use nanosleep for SCO synchronization Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 02/21] android/hal-sco: Move mtu assignment to open_stream() Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 03/21] android/hal-sco: Add SCO packet cache Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 04/21] android/hal-sco: Make use of config parameter Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 05/21] android/hal-sco: Implement open input stream Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 06/21] android/hal-sco: Check file descriptor >= 0 Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 07/21] android/hal-sco: Use global sco file descriptor Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 08/21] android/hal-sco: Make debug more readable Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 09/21] android/hal-sco: Fix memory leak Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 10/21] android/hal-sco: Implement read Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 11/21] android/hal-sco: Skip resampling for output stream with 8k Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 12/21] android/hal-sco: Skip resampling for input of 8k Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 13/21] android/hal-sco: Choose buffer size Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 14/21] android/hal-sco: Add stream synchronization Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 15/21] android/hal-sco: Get SCO audio fd on demand Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 16/21] android/hal-sco: Defer SCO connection to write() Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 17/21] android/hal-sco: Fix incorrect assignment Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 18/21] android/hal-audio: Fix leaving open socket Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 19/21] android/hal-sco: " Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 20/21] android/hal-sco: Fix error code printing Andrei Emeltchenko
2014-07-18 9:48 ` [PATCHv2 21/21] android/ipc: Rename connect_sco to get_fd Andrei Emeltchenko
2014-07-18 11:49 ` [PATCHv2 00/21] Second iteration of SCO Audio HAL fixes Szymon Janc
2014-07-18 13:26 ` [PATCH] android/ipc: Rename connect_sco to get_fd Andrei Emeltchenko
2014-07-21 8:57 ` Johan Hedberg [this message]
2014-07-21 9:53 ` [PATCHv3] " Andrei Emeltchenko
2014-07-21 13:40 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721085730.GB27596@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).