[PATCH 1/2] android/pts: Update PICS for GATT

linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/2] android/pts: Update PICS for GATT
@ 2014-07-23  9:22 Marcin Kraglak
  2014-07-23  9:22 ` [PATCH 2/2] android/pts: Update PTS results " Marcin Kraglak
  2014-07-24  8:01 ` [PATCH 1/2] android/pts: Update PICS " Johan Hedberg
  0 siblings, 2 replies; 3+ messages in thread
From: Marcin Kraglak @ 2014-07-23  9:22 UTC (permalink / raw)
  To: linux-bluetooth

---
 android/pics-gatt.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/android/pics-gatt.txt b/android/pics-gatt.txt
index 9cdbe85..0179d6d 100644
--- a/android/pics-gatt.txt
+++ b/android/pics-gatt.txt
@@ -29,7 +29,7 @@ C.4: Optional IF TSPC_GATT_1_2 is supported, otherwise Excluded
 -------------------------------------------------------------------------------
 Parameter Name	Selected	Description
 -------------------------------------------------------------------------------
-TSPC_GATT_2_1	False (*)	Attribute Protocol Supported over BR/EDR
+TSPC_GATT_2_1	True		Attribute Protocol Supported over BR/EDR
 					(L2CAP fixed channel support) (C.1)
 TSPC_GATT_2_2	True		Attribute Protocol Supported over LE (C.2)
 -------------------------------------------------------------------------------
@@ -221,7 +221,7 @@ Parameter Name	Selected	Description
 -------------------------------------------------------------------------------
 TSPC_GATT_6_2	True		Discover GATT Services using Service Discovery
 					Profile (C.1)
-TSPC_GATT_6_3	False (*)	Publish SDP record for GATT services support
+TSPC_GATT_6_3	True		Publish SDP record for GATT services support
 					via BR/EDR (C.2)
 -------------------------------------------------------------------------------
 C.1: Mandatory IF TSPC_GATT_1_1 is supported, otherwise Excluded
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] android/pts: Update PTS results for GATT
  2014-07-23  9:22 [PATCH 1/2] android/pts: Update PICS for GATT Marcin Kraglak
@ 2014-07-23  9:22 ` Marcin Kraglak
  2014-07-24  8:01 ` [PATCH 1/2] android/pts: Update PICS " Johan Hedberg
  1 sibling, 0 replies; 3+ messages in thread
From: Marcin Kraglak @ 2014-07-23  9:22 UTC (permalink / raw)
  To: linux-bluetooth

---
 android/pts-gatt.txt | 75 ++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 61 insertions(+), 14 deletions(-)

diff --git a/android/pts-gatt.txt b/android/pts-gatt.txt
index 9cf0758..d2a64be 100644
--- a/android/pts-gatt.txt
+++ b/android/pts-gatt.txt
@@ -1,8 +1,8 @@
 PTS test results for GATT
 
-PTS version: 5.1
-Tested: 19-May-2014
-Android version: 4.4.2
+PTS version: 5.2
+Tested: 22-July-2014
+Android version: 4.4.4
 
 Results:
 PASS	test passed
@@ -18,7 +18,8 @@ TC_GAC_CL_BV_01_C	PASS	haltest:
 				gattc search_service
 				gattc get_characteristic
 				gattc write_characteristic: type 3
-TC_GAC_SR_BV_01_C	PASS	haltest:
+TC_GAC_SR_BV_01_C	FAIL	PTS issue #12357
+				haltest:
 				gatts add_service
 				gatts add_chaaracteristic:
 					<properties> 10 <permissions> 17
@@ -117,8 +118,14 @@ TC_GAD_SR_BV_06_C	PASS	haltest:
 				gatts add_service
 				gatts add_included_service
 				gatts start_service
-TC_GAD_SR_BV_07_C	N/A
-TC_GAD_SR_BV_08_C	N/A
+TC_GAD_SR_BV_07_C	PASS	haltest:
+				when requested:
+				bluetooth get_remote_services
+				NOTE: check if found requested service
+TC_GAD_SR_BV_08_C	PASS	haltest:
+				when requested:
+				bluetooth get_remote_services
+				NOTE: check if found requested service
 TC_GAR_CL_BV_01_C	PASS	haltest:
 				gattc read_characteristic
 TC_GAR_CL_BI_01_C	PASS	haltest:
@@ -196,6 +203,8 @@ TC_GAR_CL_BI_25_C	PASS	haltest:
 				gattc read_descriptor
 TC_GAR_CL_BI_26_C	PASS	haltest:
 				gattc read_descriptor
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAR_CL_BI_27_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -205,6 +214,8 @@ TC_GAR_CL_BI_27_C	PASS	haltest:
 								handle from logs
 				gattc read_descriptor
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAR_CL_BV_07_C	PASS	haltest:
 				gattc read_descriptor
 TC_GAR_CL_BI_28_C	PASS	haltest:
@@ -217,6 +228,8 @@ TC_GAR_CL_BI_31_C	PASS	haltest:
 				gattc read_descriptor
 TC_GAR_CL_BI_32_C	PASS	haltest:
 				gattc read_descriptor
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAR_CL_BI_33_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -226,7 +239,12 @@ TC_GAR_CL_BI_33_C	PASS	haltest:
 								handle from logs
 				gattc read_descriptor
 				gattc disconnect
-TC_GAR_CL_BI_34_C	N/A
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
+TC_GAR_CL_BI_34_C	PASS	haltest:
+				gattc connect
+				gattc test_command 224 <addr> 0 0x0a <handle>
+				gattc disconnect
 TC_GAR_CL_BI_35_C	PASS	haltest:
 				gattc read_characteristic
 TC_GAR_SR_BV_01_C	PASS
@@ -251,7 +269,8 @@ TC_GAR_SR_BI_05_C	PASS	haltest:
 				gatts start_service
 				gatts send_response: <status> 12
 TC_GAR_SR_BV_03_C	PASS
-TC_GAR_SR_BI_06_C	PASS	haltest:
+TC_GAR_SR_BI_06_C	PASS	PTS issue #12346 tested with ETS
+				haltest:
 				gatts add_service
 				gatts add_chaaracteristic:
 						<properties> 2 <permissions> 16
@@ -432,8 +451,16 @@ TC_GAR_SR_BI_33_C	PASS	haltest:
 				gatts add_descriptor: <permissions> 1
 				gatts start_service
 				gatts send_response: <status> 12
-TC_GAR_SR_BI_34_C	N/A
-TC_GAR_SR_BI_35_C	N/A
+TC_GAR_SR_BI_34_C	PASS	haltest:
+				gatts add_service
+				gatts add_characteristic
+				gatts start_service
+				gatts send_response <status> 0x80-0x9F
+TC_GAR_SR_BI_35_C	PASS	haltest:
+				gatts add_service
+				gatts add_characteristic
+				gatts start_service
+				gatts send_response <status> 0x80-0x9F
 TC_GAW_CL_BV_01_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -441,7 +468,7 @@ TC_GAW_CL_BV_01_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic
 				gattc disconnect
-TC_GAW_CL_BV_02_C	PASS	haltest:
+TC_GAW_CL_BV_02_C	INC	haltest:
 				bluetooth create_bond
 				gattc disconnect
 				gattc connect
@@ -482,6 +509,8 @@ TC_GAW_CL_BI_05_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BI_06_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -489,6 +518,8 @@ TC_GAW_CL_BI_06_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BV_05_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -528,6 +559,8 @@ TC_GAW_CL_BI_12_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BI_13_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -535,6 +568,8 @@ TC_GAW_CL_BI_13_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BV_06_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -567,6 +602,8 @@ TC_GAW_CL_BI_18_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BI_19_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -574,6 +611,8 @@ TC_GAW_CL_BI_19_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BV_08_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -610,6 +649,8 @@ TC_GAW_CL_BI_23_C	PASS	haltest:
 				gattc get_descriptor
 				gattc write_descriptor 2 <short_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BI_24_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -618,6 +659,8 @@ TC_GAW_CL_BI_24_C	PASS	haltest:
 				gattc get_descriptor
 				gattc write_descriptor 2 <short_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BV_09_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -658,6 +701,8 @@ TC_GAW_CL_BI_30_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BI_31_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -665,6 +710,8 @@ TC_GAW_CL_BI_31_C	PASS	haltest:
 								handle from logs
 				gattc write_characteristic 2 <long_value>
 				gattc disconnect
+				NOTE: TSPX_delete_ltk must be set to true
+				PTS issue #12371
 TC_GAW_CL_BI_32_C	PASS	haltest:
 				gattc connect
 				gattc search_service
@@ -706,7 +753,7 @@ TC_GAW_CL_BI_36_C	PASS	haltest:
 TC_GAW_SR_BV_01_C	PASS	haltest:
 				gatts add_service
 				gatts add_characteristic:
-						<properties> 4 <permissions> 16
+						<properties> 4 <permissions> 17
 				gatts start_service
 TC_GAW_SR_BV_02_C	PASS	haltest:
 				gatts add service
@@ -1006,7 +1053,7 @@ TC_GAN_CL_BV_01_C	PASS	haltest:
 				gattc get_characteristic: srvc_id based on
 								handle from logs
 				gattc get_descriptor
-				gattc write_descriptor 2 <hex_value> 0001
+				gattc write_descriptor 2 <hex_value> 0100
 				gattc disconnect
 TC_GAN_SR_BV_01_C	PASS	haltest:
 				gatts add_service
@@ -1025,7 +1072,7 @@ TC_GAI_CL_BV_01_C	PASS	haltest:
 				gattc get_characteristic: srvc_id based on
 								handle from logs
 				gattc get_descriptor
-				gattc write_descriptor 2 <hex_value> 0002
+				gattc write_descriptor 2 <hex_value> 0200
 				gattc disconnect
 TC_GAI_SR_BV_01_C	PASS	haltest:
 				gatts add_service
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] android/pts: Update PICS for GATT
  2014-07-23  9:22 [PATCH 1/2] android/pts: Update PICS for GATT Marcin Kraglak
  2014-07-23  9:22 ` [PATCH 2/2] android/pts: Update PTS results " Marcin Kraglak
@ 2014-07-24  8:01 ` Johan Hedberg
  1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2014-07-24  8:01 UTC (permalink / raw)
  To: Marcin Kraglak; +Cc: linux-bluetooth

Hi Marcin,

On Wed, Jul 23, 2014, Marcin Kraglak wrote:
> ---
>  android/pics-gatt.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Both patches have been applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-24  8:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23  9:22 [PATCH 1/2] android/pts: Update PICS for GATT Marcin Kraglak
2014-07-23  9:22 ` [PATCH 2/2] android/pts: Update PTS results " Marcin Kraglak
2014-07-24  8:01 ` [PATCH 1/2] android/pts: Update PICS " Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).