linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv3 4/5] monitor: Handle default switch case
Date: Wed, 13 Aug 2014 12:19:13 +0300	[thread overview]
Message-ID: <20140813091913.GA19215@t440s.lan> (raw)
In-Reply-To: <1407847596-14781-4-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

On Tue, Aug 12, 2014, Andrei Emeltchenko wrote:
> Fixes issues with junk packets.
> ---
>  monitor/analyze.c | 3 +++
>  1 file changed, 3 insertions(+)

I've applied the four other patches, but there's a small fix needed for
this one:

> +		default:
> +			fprintf(stderr, "Wrong opcode %u", opcode);
> +			goto done;

Seems like you've forgotten a \n at the end of the string.

Johan

  reply	other threads:[~2014-08-13  9:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11  7:50 [PATCHv2 01/10] monitor: Fix segmentation fault with malformed packet Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 02/10] monitor: Handle default switch case Andrei Emeltchenko
2014-08-11 13:25   ` Johan Hedberg
2014-08-11  7:50 ` [PATCHv2 03/10] emulator: Fix resource leak closing fd Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 04/10] tools: Fix resource leak closing sk Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 05/10] gobex: Fix use after free Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 06/10] " Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 07/10] " Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 08/10] proximity: " Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 09/10] gdbus: " Andrei Emeltchenko
2014-08-11  7:50 ` [PATCHv2 10/10] obexd: Fix possible NULL dereference Andrei Emeltchenko
2014-08-11 13:37   ` Johan Hedberg
2014-08-12  7:57     ` Andrei Emeltchenko
2014-08-11 13:22 ` [PATCHv2 01/10] monitor: Fix segmentation fault with malformed packet Johan Hedberg
2014-08-12  7:55   ` Andrei Emeltchenko
2014-08-12  9:04     ` Johan Hedberg
2014-08-12 12:46       ` [PATCHv3 1/5] monitor: Use common maximum packet size definition Andrei Emeltchenko
2014-08-12 12:46         ` [PATCHv3 2/5] shared/btsnoop: Fix segmentation fault with malformed packet Andrei Emeltchenko
2014-08-12 12:46         ` [PATCHv3 3/5] btmon: " Andrei Emeltchenko
2014-08-12 12:46         ` [PATCHv3 4/5] monitor: Handle default switch case Andrei Emeltchenko
2014-08-13  9:19           ` Johan Hedberg [this message]
2014-08-13 11:32             ` [PATCHv4] " Andrei Emeltchenko
2014-08-13 11:42               ` Johan Hedberg
2014-08-12 12:46         ` [PATCHv3 5/5] obexd: Fix possible NULL dereference Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813091913.GA19215@t440s.lan \
    --to=johan.hedberg@gmail.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).