From: Johan Hedberg <johan.hedberg@gmail.com>
To: Arman Uguray <armansito@chromium.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ v1 4/7] shared/gatt-client: Handle incoming not/ind PDUs.
Date: Tue, 9 Sep 2014 17:29:54 -0700 [thread overview]
Message-ID: <20140910002954.GA7572@t440s> (raw)
In-Reply-To: <CAHrH25SVxPLYdjAGNHSwOKLx60wUOSRTzBTHDJfmvpFkiFhRPA@mail.gmail.com>
Hi Arman,
On Tue, Sep 09, 2014, Arman Uguray wrote:
> >> + unsigned int notify_id, indic_id;
> >
> > I have never seen indication shorted into indic. I have to say that
> > I do not like it that much. However I do not have any good
> > suggestion either.
> >
>
> Perhaps "indicn_id"? I could just spell out "indication_id" :P.
What's wrong with "ind"? It's used in many places in the tree as a
shorthand for indication and even shared/att.c uses it. On the other
hand if you want to match the grammatical form of notify_id you should
use indicate_id (which feels much worse to me). Third option that comes
to mind if we want short versions of both is "ind" and "nfy", but not
sure how decipherable the latter is.
Johan
next prev parent reply other threads:[~2014-09-10 0:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 17:04 [PATCH BlueZ v1 0/7] shared/gatt-client: Handle notifications Arman Uguray
2014-09-09 17:04 ` [PATCH BlueZ v1 1/7] shared/gatt-client: Introduce struct bt_gatt_characteristic_iter Arman Uguray
2014-09-09 17:04 ` [PATCH BlueZ v1 2/7] shared/gatt-client: Implement bt_gatt_client_register_notify Arman Uguray
2014-09-09 17:04 ` [PATCH BlueZ v1 3/7] shared/gatt-client: Implement bt_gatt_client_unregister_notify Arman Uguray
2014-09-09 22:54 ` Marcel Holtmann
2014-09-09 17:04 ` [PATCH BlueZ v1 4/7] shared/gatt-client: Handle incoming not/ind PDUs Arman Uguray
2014-09-09 22:58 ` Marcel Holtmann
2014-09-10 0:09 ` Arman Uguray
2014-09-10 0:29 ` Johan Hedberg [this message]
2014-09-10 0:48 ` Arman Uguray
2014-09-10 2:04 ` Marcel Holtmann
2014-09-10 2:06 ` Marcel Holtmann
2014-09-10 16:24 ` Arman Uguray
2014-09-09 17:04 ` [PATCH BlueZ v1 5/7] tools/btgatt-client: Add the "register-notify" command Arman Uguray
2014-09-09 17:04 ` [PATCH BlueZ v1 6/7] tools/btgatt-client: Add "unregister-notify" command Arman Uguray
2014-09-09 17:04 ` [PATCH BlueZ v1 7/7] TODO: Reference counted notify functions implemented Arman Uguray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910002954.GA7572@t440s \
--to=johan.hedberg@gmail.com \
--cc=armansito@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox