From: Alexander Aring <alex.aring@gmail.com>
To: Martin Townsend <mtownsend1973@gmail.com>
Cc: linux-zigbee-devel@lists.sourceforge.net,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
marcel@holtmann.org, Martin Townsend <martin.townsend@xsilon.com>
Subject: Re: [PATCH][linux-bluetooth 1/3] 6lowpan: skb freed locally from lowpan_rcv
Date: Thu, 11 Sep 2014 10:07:59 +0200 [thread overview]
Message-ID: <20140911080758.GB19178@omega> (raw)
In-Reply-To: <20140911075830.GA19178@omega>
On Thu, Sep 11, 2014 at 09:58:30AM +0200, Alexander Aring wrote:
...
> >
> > @@ -490,14 +490,14 @@ static int lowpan_rcv(struct sk_buff *skb, struct net_device *dev,
> > } else {
> > switch (skb->data[0] & 0xe0) {
> > case LOWPAN_DISPATCH_IPHC: /* ipv6 datagram */
> > - ret = process_data(skb, &hdr);
> > + ret = process_data(&skb, &hdr);
> > if (ret == NET_RX_DROP)
> > goto drop;
>
> the conversion from errno to NET_RX_DROP here.
>
> if (ret < 0)
> goto drop;
>
should be more drop_skb here, since we removed the kfree_skb in
process_data. ... I know the error handling is a mess, but was also
before I start to working with it. :-)
Thanks, that you accept this challenge to fix it. ;-)
- Alex
next prev parent reply other threads:[~2014-09-11 8:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 14:06 [PATCH][linux-bluetooth 0/3] Fix lowpan_rcv Martin Townsend
2014-09-10 14:06 ` Martin Townsend
2014-09-10 14:06 ` [PATCH][linux-bluetooth 1/3] 6lowpan: skb freed locally from lowpan_rcv Martin Townsend
2014-09-11 7:58 ` Alexander Aring
2014-09-11 8:07 ` Alexander Aring [this message]
2014-09-11 8:32 ` Martin Townsend
2014-09-10 14:06 ` [PATCH][linux-bluetooth 2/3] 6lowpan: Move skb delivery from IPHC Martin Townsend
2014-09-11 8:18 ` Alexander Aring
2014-09-11 8:25 ` Martin Townsend
2014-09-11 9:01 ` Alexander Aring
2014-09-11 9:33 ` Martin Townsend
2014-09-11 9:53 ` Alexander Aring
2014-09-11 10:12 ` Martin Townsend
2014-09-11 10:25 ` Alexander Aring
2014-09-12 9:18 ` Jukka Rissanen
2014-09-11 14:11 ` Marcel Holtmann
2014-09-10 14:06 ` [PATCH][linux-bluetooth 3/3] 6lowpan: Refactored lowpan_rcv so it's RFC compliant Martin Townsend
2014-09-11 8:53 ` Alexander Aring
2014-09-11 9:09 ` Alexander Aring
2014-09-11 9:21 ` Alexander Aring
2014-09-11 9:30 ` Martin Townsend
2014-09-11 9:50 ` Alexander Aring
2014-09-11 10:09 ` Martin Townsend
2014-09-11 10:33 ` Alexander Aring
2014-09-11 10:45 ` Martin Townsend
2014-09-11 10:55 ` Alexander Aring
2014-09-11 11:00 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911080758.GB19178@omega \
--to=alex.aring@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=marcel@holtmann.org \
--cc=martin.townsend@xsilon.com \
--cc=mtownsend1973@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).