From: Johan Hedberg <johan.hedberg@gmail.com>
To: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Cc: linux-bluetooth@vger.kernel.org, d.kasatkin@samsung.com,
bharat.panda@samsung.com, cpgs@samsung.com
Subject: Re: [PATCH 1/7] obexd/client : Handle the MAP Extended Event Report 1.1
Date: Thu, 11 Sep 2014 09:37:52 -0700 [thread overview]
Message-ID: <20140911163752.GA27789@t440s> (raw)
In-Reply-To: <1410441607-9687-1-git-send-email-gowtham.ab@samsung.com>
Hi,
On Thu, Sep 11, 2014, Gowtham Anandha Babu wrote:
> struct map_event {
> @@ -41,6 +42,10 @@ struct map_event {
> char *folder;
> char *old_folder;
> char *msg_type;
> + char *datetime;
> + char *subject;
> + char *sender_name;
> + char *priority;
> };
<snip>
> +static void parse_event_report_date_time(struct map_event *event,
> + const char *value)
> +{
> + event->datetime = g_strdup(value);
> +}
> +
> +static void parse_event_report_subject(struct map_event *event,
> + const char *value)
> +{
> + event->subject = g_strdup(value);
> +}
> +
> +static void parse_event_report_sender_name(struct map_event *event,
> + const char *value)
> +{
> + event->sender_name = g_strdup(value);
> +}
> +
> +static void parse_event_report_priority(struct map_event *event,
> + const char *value)
> +{
> + event->priority = g_strdup(value);
> +}
Where are all these freed? Don't you need to update the map_event_free()
function? If you're not yet doing so, please always test your code with
"valgrind --leak-check=full".
Johan
next prev parent reply other threads:[~2014-09-11 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 13:20 [PATCH 1/7] obexd/client : Handle the MAP Extended Event Report 1.1 Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 2/7] obexd/client/map : Handle MAP ReadStatusChanged event type Gowtham Anandha Babu
2014-09-11 21:00 ` Luiz Augusto von Dentz
2014-09-12 13:43 ` Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 3/7] tools/btsnoop : Fix variable reassigning issue Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 4/7] tools/csr_usb : Fix Resource leak: file Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 5/7] tools/seq2bseq : Fix the same expression issue in if condition Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 6/7] tools/hciattach : Fix syntax error Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 7/7] android/hal-utils.c : Fix null pointer dereference Gowtham Anandha Babu
2014-09-19 7:08 ` Szymon Janc
2014-09-11 16:37 ` Johan Hedberg [this message]
2014-09-11 20:45 ` [PATCH 1/7] obexd/client : Handle the MAP Extended Event Report 1.1 Luiz Augusto von Dentz
2014-09-12 13:49 ` Gowtham Anandha Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911163752.GA27789@t440s \
--to=johan.hedberg@gmail.com \
--cc=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=d.kasatkin@samsung.com \
--cc=gowtham.ab@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).