From: Johan Hedberg <johan.hedberg@gmail.com>
To: gowtham babu <gowtham.ab@samsung.com>
Cc: linux-bluetooth@vger.kernel.org, d.kasatkin@samsung.com,
bharat.panda@samsung.com, cpgs@samsung.com
Subject: Re: [PATCH] tools/seq2bseq : Fix the same expression issue in if condition
Date: Fri, 12 Sep 2014 09:57:30 -0700 [thread overview]
Message-ID: <20140912165730.GC3671@t440s> (raw)
In-Reply-To: <1410331363-3548-1-git-send-email-gowtham.ab@samsung.com>
Hi,
On Wed, Sep 10, 2014, gowtham babu wrote:
> Below are the list of similar patches under 'tools' which are not yet reviewed
>
> 1) tools/csr_usb : Fix Resource leak: file
> 2) tools/hciattach : Fix syntax error
> 3) tools/btsnoop : Fix variable reassigning issue
This kind of stuff does not belong in a commit message.
> diff --git a/tools/seq2bseq.c b/tools/seq2bseq.c
> index 7657a57..521d20e 100644
> --- a/tools/seq2bseq.c
> +++ b/tools/seq2bseq.c
> @@ -40,7 +40,7 @@ static int convert_line(int fd, const char *line)
> char str[3];
> unsigned char val;
>
> - if (line[0] == '*' || line[0] == '\r' || line[0] == '\r')
> + if (line[0] == '*' || line[0] == '\r')
> return 0;
>
> while (1) {
Are you sure the code wasn't intending to check for '\n'?
Johan
next prev parent reply other threads:[~2014-09-12 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 6:42 [PATCH] tools/seq2bseq : Fix the same expression issue in if condition gowtham babu
2014-09-12 16:57 ` Johan Hedberg [this message]
2014-09-12 17:05 ` Marcel Holtmann
2014-09-15 6:14 ` Gowtham Anandha Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912165730.GC3671@t440s \
--to=johan.hedberg@gmail.com \
--cc=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=d.kasatkin@samsung.com \
--cc=gowtham.ab@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).